From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11943 invoked by alias); 13 Aug 2014 15:21:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11931 invoked by uid 89); 13 Aug 2014 15:21:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout23.012.net.il Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Aug 2014 15:21:37 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NA900I003YT8Y00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 13 Aug 2014 18:21:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA900ILV3ZY6D50@a-mtaout23.012.net.il>; Wed, 13 Aug 2014 18:21:34 +0300 (IDT) Date: Wed, 13 Aug 2014 15:21:00 -0000 From: Eli Zaretskii Subject: Re: Warnings in native MinGW32 build of GDB 7.8 In-reply-to: <53EAE47A.6030700@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83k36cifeq.fsf@gnu.org> References: <83r40plpp3.fsf@gnu.org> <53EAE47A.6030700@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00239.txt.bz2 > Date: Wed, 13 Aug 2014 12:07:22 +0800 > From: Yao Qi > > On 08/09/2014 10:09 PM, Eli Zaretskii wrote: > > I fixed that as below, but I wonder why no one else saw this. is this > > because I use an ancient version of GCC? > > I don't see any warning in my mingw32 build. I am using > i686-w64-mingw32-gcc 4.8.2. Your GCC version is eons ahead of mine, and from a different distro on top of that. > > OK to commit the below (master and 7.8 branch), with suitable > > ChangeLog entries? > > > > --- gdb/dcache.c~0 2014-07-29 15:37:42.000000000 +0300 > > +++ gdb/dcache.c 2014-08-09 16:17:31.823000000 +0300 > > @@ -18,6 +18,7 @@ > > along with this program. If not, see . */ > > > > #include "defs.h" > > +#include "target.h" /* for 'enum target_xfer_status' */ > > I can see enum target_xfer_status is used in this c file. This is good > to me. Not sure what you mean here. Do you agree with this change? If not, why not? > > #include "dcache.h" > > #include "gdbcmd.h" > > #include > > > > --- gdb/defs.h~0 2014-07-29 15:37:42.000000000 +0300 > > +++ gdb/defs.h 2014-08-09 15:33:59.666750000 +0300 > > @@ -628,6 +628,7 @@ > > #endif /* alloca not defined */ > > > > /* Dynamic target-system-dependent parameters for GDB. */ > > +#include "frame.h" /* for 'struct frame_id' */ > > It is unclear to me why do we need this include? Because 'struct frame_id' is otherwise not defined, and I get warnings like this one: In file included from defs.h:631, from gdb.c:19: gdbarch.h:429: warning: parameter has incomplete type gdbarch.h:430: warning: parameter has incomplete type > > --- gdb/target-dcache.c~0 2014-06-11 19:34:41.000000000 +0300 > > +++ gdb/target-dcache.c 2014-08-09 16:17:42.244875000 +0300 > > @@ -16,6 +16,7 @@ > > along with this program. If not, see . */ > > > > #include "defs.h" > > +#include "target.h" /* for 'enum target_xfer_status' */ > > enum target_xfer_status isn't used in target-dcache.c. Do we really > need this? It is used in dcache.h which target-dcache.c includes: In file included from target-dcache.h:21, from target-dcache.c:19: dcache.h:42: warning: parameter has incomplete type Thanks for reviewing the patch.