From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119447-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29528 invoked by alias); 29 Jan 2015 17:11:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29497 invoked by uid 89); 29 Jan 2015 17:11:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout28.012.net.il
Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jan 2015 17:11:11 +0000
Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NIY0000077IIY00@mtaout28.012.net.il> for gdb-patches@sourceware.org; Thu, 29 Jan 2015 19:08:01 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIY00JF67LCU660@mtaout28.012.net.il>; Thu, 29 Jan 2015 19:08:01 +0200 (IST)
Date: Thu, 29 Jan 2015 19:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3 04/15] record btrace: add configuration struct
In-reply-to: <1422548899-9789-5-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k305ms2s.fsf@gnu.org>
References: <1422548899-9789-1-git-send-email-markus.t.metzger@intel.com> <1422548899-9789-5-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00781.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 29 Jan 2015 17:28:08 +0100
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -14,6 +14,17 @@
>  * The command 'thread apply all' can now support new option '-ascending'
>    to call its specified command for all threads in ascending order.
>  
> +* New commands
> +
> +record btrace bts
> +record bts
> +  Start branch trace recording using Intel(R) Branch Trace Store format.
> +
> +* New remote packets
> +
> +qXfer:btrace-conf:read
> +  Return the branch trace configuration for the current thread.
> +
>  *** Changes in GDB 7.9

This part is OK.

> +@table @code
> +@item bts
> +Use Intel's Branch Trace Store (BTS) recording format.  In this format,
> +the processor stores a from/to record for each executed branch in the
> +btrace ring buffer.

Please us @dfn{...} around "Branch Trace Store" (it's new
terminology), and please use "@acronym{BTS}".

Also, please add a @cindex entry for "branch trace store" here.

The documentation parts are OK with these fixed.

Thanks.