From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125036-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 83912 invoked by alias); 6 Aug 2015 14:46:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 83744 invoked by uid 89); 6 Aug 2015 14:46:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout29.012.net.il
Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Aug 2015 14:46:01 +0000
Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NSO00G000NQDF00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Thu, 06 Aug 2015 17:45:08 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSO00EYF0Z8MA20@mtaout29.012.net.il>; Thu, 06 Aug 2015 17:45:08 +0300 (IDT)
Date: Thu, 06 Aug 2015 14:46:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] btrace: indicate speculative execution
In-reply-to: <1438867238-28224-1-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k2t8scg0.fsf@gnu.org>
References: <1438867238-28224-1-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00151.txt.bz2

> 2015-08-06  Markus Metzger  <markus.t.metzger@intel.com>
> 
> 	* btrace.c (btrace_compute_ftrace_bts): Clear insn flags.
> 	(pt_btrace_insn_flags): New.
> 	(ftrace_add_pt): Call pt_btrace_insn_flags.
> 	* btrace.h (btrace_insn_flag): New.
> 	(btrace_insn) <flags>: New.
> 	* record-btrace.c (btrace_insn_history): Print insn prefix.
> 	* NEWS: Announce it.
> 
> doc/
> 	* gdb.texinfo (Process Record and Replay): Document it.

doc/ has a separate ChangeLog file, so you cannot say just "Document
it." and hope people will somehow read that right after the main log
entry.

> +Speculatively executed instructions are prefixed with @code{?}.  This

Please use @samp here, not code, so that the question mark is quoted
in the printed manual as well.

The documentation parts are OK with those changes.

Thanks.