From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125522 invoked by alias); 13 Dec 2017 16:17:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125512 invoked by uid 89); 13 Dec 2017 16:17:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=tromey X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 16:17:15 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eP9iX-0003C9-Hz for gdb-patches@sourceware.org; Wed, 13 Dec 2017 11:17:13 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eP9hu-0002SJ-Jn; Wed, 13 Dec 2017 11:16:30 -0500 Received: from [176.228.60.248] (port=2517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eP9hu-0006Bl-3W; Wed, 13 Dec 2017 11:16:30 -0500 Date: Wed, 13 Dec 2017 16:17:00 -0000 Message-Id: <83k1xqvc14.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, tom@tromey.com, simon.marchi@ericsson.com, palves@redhat.com, keiths@redhat.com In-reply-to: <20171213031724.22721-3-sergiodj@redhat.com> (message from Sergio Durigan Junior on Tue, 12 Dec 2017 22:17:24 -0500) Subject: Re: [PATCH v5 2/2] Implement pahole-like 'ptype /o' option Reply-to: Eli Zaretskii References: <20171121160709.23248-1-sergiodj@redhat.com> <20171213031724.22721-1-sergiodj@redhat.com> <20171213031724.22721-3-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00310.txt.bz2 > From: Sergio Durigan Junior > Cc: Tom Tromey , Eli Zaretskii , Simon Marchi , Pedro Alves , Keith Seitz , Sergio Durigan Junior > Date: Tue, 12 Dec 2017 22:17:24 -0500 > > This commit implements the pahole-like '/o' option for 'ptype', which > +Issuing a @kbd{ptype /o struct tuv} would print: ^ Please insert "command" after the command, where I indicated. Otherwise the sentence reads awkward. > +Notice the format of the first column of comments. There, you can > +find two parts separated by the @code{|} character: the @emph{offset}, ^^^^^^^^ @samp, not @code. The documentation parts are okay with these fixed. Thanks.