From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73657 invoked by alias); 21 Aug 2018 16:16:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73572 invoked by uid 89); 21 Aug 2018 16:16:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=3, 1, H*r:eggs.gnu.org, H*r:4.71 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 16:15:52 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fs9Jl-0004Uw-Oz for gdb-patches@sourceware.org; Tue, 21 Aug 2018 12:15:45 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs9Jf-0004Oh-LZ; Tue, 21 Aug 2018 12:15:39 -0400 Received: from [176.228.60.248] (port=2845 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fs9Jd-000426-TH; Tue, 21 Aug 2018 12:15:35 -0400 Date: Tue, 21 Aug 2018 16:16:00 -0000 Message-Id: <83k1ojd7bv.fsf@gnu.org> From: Eli Zaretskii To: Jan Vrany CC: gdb-patches@sourceware.org In-reply-to: <20180820204250.16301-1-jan.vrany@fit.cvut.cz> (message from Jan Vrany on Mon, 20 Aug 2018 21:42:50 +0100) Subject: Re: [RFC] mi: print frame architecture when printing frames on an MI channel References: <74309b49-5797-d98b-8381-7da59be91362@redhat.com> <20180820204250.16301-1-jan.vrany@fit.cvut.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00493.txt.bz2 > From: Jan Vrany > Cc: Jan Vrany > Date: Mon, 20 Aug 2018 21:42:50 +0100 > > When printing frames on an MI channel also print frame architecture > like in: > > (gdb) > -stack-list-frames 3 3 > ^done,stack= > [frame={level="3",addr="0x000107a4",func="foo", > file="recursive2.c",fullname="/home/foo/bar/recursive2.c", > line="14",arch="i386:x86_64"}] > (gdb) > > This is useful for MI clients that need to know the architecture in order > to perform further analysis, for example to use their own disassembler to > analyze machine code. Thanks. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -41,6 +41,11 @@ thread apply [all | COUNT | -COUNT] [FLAG]... COMMAND > FLAG arguments allow to control what output to produce and how to handle > errors raised when applying COMMAND to a thread. > > +* MI changes > + > + ** Command responses and notifications that include a frame now include > + the frame's architecture in a new "arch" attribute. > + This is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index b931834400..635275d3ec 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -28001,7 +28001,7 @@ reason that execution stopped. > <- *stopped,reason="breakpoint-hit",disp="keep",bkptno="1",thread-id="0", > frame=@{addr="0x08048564",func="main", > args=[@{name="argc",value="1"@},@{name="argv",value="0xbfc4d4d4"@}], > - file="myprog.c",fullname="/home/nickrob/myprog.c",line="68"@} > + file="myprog.c",fullname="/home/nickrob/myprog.c",line="68",arch="i386:x86_64"@} The modified line is now too long, please split it into two, otherwise it might look badly in the printed version of the manual. > @@ -28684,7 +28684,7 @@ for the watchpoint going out of scope. > wpt=@{number="5",exp="C"@},value=@{old="-276895068",new="3"@}, > frame=@{func="callee4",args=[], > file="../../../devo/gdb/testsuite/gdb.mi/basics.c", > -fullname="/home/foo/bar/devo/gdb/testsuite/gdb.mi/basics.c",line="13"@} > +fullname="/home/foo/bar/devo/gdb/testsuite/gdb.mi/basics.c",line="13",arch="i386:x86_64"@} Likewise here, and everywhere else in the patch for the manual. OK with those fixed.