From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71343 invoked by alias); 24 Dec 2018 16:14:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71332 invoked by uid 89); 24 Dec 2018 16:14:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Cygwin, D*ca, stepping X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 16:14:09 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbSrj-0007u3-TG for gdb-patches@sourceware.org; Mon, 24 Dec 2018 11:14:07 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbSrj-0007tu-Pk; Mon, 24 Dec 2018 11:14:03 -0500 Received: from [176.228.60.248] (port=4483 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gbSrj-0005gQ-DC; Mon, 24 Dec 2018 11:14:03 -0500 Date: Mon, 24 Dec 2018 16:14:00 -0000 Message-Id: <83k1jy9a2k.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: (message from Simon Marchi on Sun, 23 Dec 2018 18:31:45 -0500) Subject: Re: GDB internal error in pc_in_thread_step_range References: <83h8kjr8r6.fsf@gnu.org> <100001f1b27aa7d90902a75d5db37710@polymtl.ca> <83a7m6tk92.fsf@gnu.org> <8336qxfpjo.fsf@gnu.org> <83tvjde68l.fsf@gnu.org> <83ftutcy7p.fsf@gnu.org> <659d33b5e4af35aea6c3aaef08559f31@polymtl.ca> <837eg4cick.fsf@gnu.org> <988ca92d2c5c976fbea57c2381eb6279@polymtl.ca> <834lb6ar3g.fsf@gnu.org> <83sgyo8brg.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00300.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Simon Marchi > Date: Sun, 23 Dec 2018 18:31:45 -0500 > > On 2018-12-23 11:10 a.m., Eli Zaretskii wrote: > > Like this? > > > > --- gdb/coffread.c~1 2018-07-04 18:41:59.000000000 +0300 > > +++ gdb/coffread.c 2018-12-23 10:24:15.758116900 +0200 > > @@ -874,8 +874,10 @@ coff_symtab_read (minimal_symbol_reader > > int section = cs_to_section (cs, objfile); > > > > tmpaddr = cs->c_value; > > - record_minimal_symbol (reader, cs, tmpaddr, mst_text, > > - section, objfile); > > + /* Don't record unresolved symbols. */ > > + if (!(cs->c_secnum <= 0 && cs->c_value == 0)) > > + record_minimal_symbol (reader, cs, tmpaddr, mst_text, > > + section, objfile); > > > > fcn_line_ptr = main_aux.x_sym.x_fcnary.x_fcn.x_lnnoptr; > > fcn_start_addr = tmpaddr; > > That looks good to me. Should I push it to the master branch? > > I'm sorry, I don't have such a setup, either. Can anyone else run the > > regression tests? If not, how are MinGW related changes tested when > > submitted here? > > I thought you were the MinGW reference around here :). I'm happy to help with this, but setting up the GDB test suite needs a Cygwin installation as well, and I don't have that. > > The change above causes the following behavior, when stepping out of > > 'main' with "next": > > > > 6 return 0; > > (gdb) n > > 7 } > > (gdb) > > 0x00401288 in ?? () > > (gdb) n > > Cannot find bounds of current function > > (gdb) c > > Continuing. > > [Inferior 1 (process 9228) exited normally] > > (gdb) q > > > > If this is fine with you, it's fine with me. > > That seems good to me, given the information GDB works with. I agree, so I'd like to install this patch.