Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 3/3] NEWS and documentation for new info sources [-d | -b] [--] [REGEXP] args
Date: Sun, 31 Mar 2019 19:16:00 -0000	[thread overview]
Message-ID: <83k1gehn3f.fsf@gnu.org> (raw)
In-Reply-To: <20190331190803.7248-4-philippe.waroquiers@skynet.be> (message	from Philippe Waroquiers on Sun, 31 Mar 2019 21:08:03 +0200)

> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 31 Mar 2019 21:08:03 +0200
> 
> gdb/doc/ChangeLog
> 2019-03-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
>         * gdb.texinfo (info sources): Document new args.

The name in the parentheses should be the name of the @node where you
are making changes.  I don't think that's "info sources", is it?

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -16,6 +16,14 @@
>  
>  * Support for Pointer Authentication on AArch64 Linux.
>  
> +* Changed commands
> +
> +info sources [-d | -b] [--] [REGEXP]
> +  This command has now optional arguments to only print the files
> +  whose names match REGEXP.  The arguments -d and -b allow to
> +  restrict matching respectively to the dirname and basename
> +  parts of the files.

This part is OK.

> +@item info sources [-d | -b] [--] [@var{regexp}]
> +Like @samp{info sources}, but only print the names of the files
> +matching the provided regexp.
                         ^^^^^^
"@var{regexp}", to reference the command's argument.

> +By default, the regexp is used to match anywhere in the filename.
                   ^^^^^^
And here.

> +If -d, only files having a dirname matching regexp are shown.
> +If -b, only files having a basename matching regexp are shown.

And here.

OK with those fixed.

Thanks.


  reply	other threads:[~2019-03-31 19:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-31 19:08 [RFA 0/3] new arguments [-d | -b] [--] [REGEXP] to info sources Philippe Waroquiers
2019-03-31 19:08 ` [RFA 2/3] New test for 'info sources [-d | -b] [--] [REGEXP]' Philippe Waroquiers
2019-06-07 18:11   ` Tom Tromey
2019-03-31 19:08 ` [RFA 3/3] NEWS and documentation for new info sources [-d | -b] [--] [REGEXP] args Philippe Waroquiers
2019-03-31 19:16   ` Eli Zaretskii [this message]
2019-03-31 19:08 ` [RFA 1/3] Implement info sources args [-d | -b] [--] [REGEXP] Philippe Waroquiers
2019-06-07 18:09   ` Tom Tromey
2019-04-18  4:18 ` PING Re: [RFA 0/3] new arguments [-d | -b] [--] [REGEXP] to info sources Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1gehn3f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox