Re: [PATCH] Add an Objfile.lookup_global_symbol function

Eli Zaretskii
2019-07-09T15:42:00Z

> Date: Mon, 8 Jul 2019 16:59:06 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 34c544c3d5..922010ed39 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -36,6 +36,9 @@
> ** gdb.Type has a new property 'objfile' which returns the objfile the
> type was defined in.
>
> + ** gdb.Objfile has a new method 'lookup_global_symbol' to lookup a symbol
> + from this objfile only.
> +

This part is OK.

> +The @var{domain} argument must be a domain constant defined in the @code{gdb}
> +module and described in the @xref{Symbols In Python} section. This function is

@ref, not @xref. The latter produces a capitalized "See", which is
inappropriate in the middle of a sentence. Also, please remove the
"section" part after the closing brace; it's redundant.

The documentation parts are OK with these nits fixed.

Thanks.