Re: [PATCH] Add an Objfile.lookup_global_symbol function

Eli Zaretskii
2019-07-23T14:47:55Z

> From: Simon Marchi <simark@simark.ca>
> Date: Mon, 22 Jul 2019 21:30:08 -0400
>
> > + { "lookup_global_symbol", (PyCFunction) objfpy_lookup_global_symbol,
> > + METH_VARARGS | METH_KEYWORDS,
> > + "lookup_global_symbol (name [, domain]).\n\
> > +Looks up a global symbol in this objfile and returns it." },
> > +
>
> To be consistent with the rest of the Python function help strings, I think it should
> be
>
> "Look up a global symbol in this objfile and return it."
>
> i.e. not at the third person of the singular. Eli, could you tell which form is preferred?

Your (Simon's) suggestion is the preferred form.

Thanks.