From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157710-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 112753 invoked by alias); 23 Jul 2019 14:54:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 112745 invoked by uid 89); 23 Jul 2019 14:54:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:506, our
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jul 2019 14:54:17 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55865)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hpwBD-0007MA-Eb; Tue, 23 Jul 2019 10:54:15 -0400
Received: from [176.228.60.248] (port=3321 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hpwBC-00030P-TF; Tue, 23 Jul 2019 10:54:15 -0400
Date: Tue, 23 Jul 2019 14:54:00 -0000
Message-Id: <83k1c8pzsk.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20190722205121.89189-1-cbiesinger@google.com>	(gdb-patches@sourceware.org)
Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
References: <20190625220832.247935-1-cbiesinger@google.com> <20190722205121.89189-1-cbiesinger@google.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-07/txt/msg00538.txt.bz2

> Date: Mon, 22 Jul 2019 15:51:21 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
> 
> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> +Searches for a global symbol named @var{name} in this objfile.  Optionally, the

As mentioned elsewhere, our convention is to say "Search for a global
symbol named ...".

Otherwise, the documentation parts are OK.