Re: [PATCH] Add an Objfile.lookup_global_symbol function

Eli Zaretskii
2019-06-27T02:36:08Z

> From: Tom Tromey <tom@tromey.com>
> Cc: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
> Date: Wed, 26 Jun 2019 15:05:34 -0600
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> >> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> >> +Searches for a global symbol by name in this objfile. Optionally, the
> Eli> ^^
> Eli> Two spaces between sentences (here and elsewhere in the patch),
> Eli> please.
>
> I wonder whether the parameter names ought to be wrapped in @var{}.

It should, thanks for catching that.