From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9341 invoked by alias); 14 Oct 2019 17:12:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9333 invoked by uid 89); 14 Oct 2019 17:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=violate, affiliated, emails X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 17:12:27 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iK3tR-0001tY-8U; Mon, 14 Oct 2019 13:12:25 -0400 Received: from [176.228.60.248] (port=1273 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iK3tQ-0001hz-8l; Mon, 14 Oct 2019 13:12:24 -0400 Date: Mon, 14 Oct 2019 17:12:00 -0000 Message-Id: <83k197i74c.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: (message from Simon Marchi on Mon, 14 Oct 2019 11:18:36 -0400) Subject: Re: Gerrit (was: [PATCH] gdb: remove unused includes from dwarf2read.c) References: <20191013045218.3261363-1-simon.marchi@polymtl.ca> <1c1f820fa507243fd7a2096ec3eb2454@polymtl.ca> <83r23fie80.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00373.txt.bz2 > Date: Mon, 14 Oct 2019 11:18:36 -0400 > From: Simon Marchi > Cc: gdb-patches@sourceware.org > > > Does this mean that now we need to look for patches in two places? > > Can Gerrit be set up to forward the review comments to the list? > > > > Also, if some of us decides to do the review on Gerrit, does it mean > > all the others need to do that as well? > > Hi Eli, > > Yes, Gerrit can be set to send notifications to an arbitrary email, so > we can set it to send them to gdb-patches. We have talked about that > earlier, it's just not done yet. I'll look into it right now. I see some emails from Gerrit, does it mean you already set that up? Because those emails leave a lot to be desired, IMO. Anyway, seeing the beginning of a patch was the only way for me to know that a patch needs me to review the documentation parts. Now I wonder how I can do that when the patch is posted on Gerrit. > As long as we use Gerrit and mail patches in parallel, people are free > to send patches using the system they prefer. I think it's simpler if > reviewers use the system that was chosen by the patch author (reply on > Gerrit if the patch is on Gerrit, reply by email if the patch is by > email). But I cannot reply on Gerrit without registering there, can I? I'm also somewhat bothered by what I've read on the wiki. I understand that anyone can register on Gerrit, and after that push patches for review, independently of their write access to the sourceware repository. Then, if gnutoolchain-gerrit.osci.io is associated with or operated by FSF/GNU, it would mean we provide a way for random people to push changes to GDB to a public repository affiliated with us, without having any control on what is being pushed ahead of the push. Suppose someone pushes there changes that violate the GPL, or do something else that is against the GNU policies -- wouldn't that appear as if we are "authorizing" those just by having that code in the repository, even though it's on a branch and haven't yet been admitted to sourceware? Thanks.