From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 95C403857005
 for <gdb-patches@sourceware.org>; Fri, 17 Jul 2020 05:54:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 95C403857005
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:36284)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jwJK3-0003F7-Bp; Fri, 17 Jul 2020 01:54:15 -0400
Received: from [176.228.60.248] (port=3965 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jwJK2-0006Hn-Rk; Fri, 17 Jul 2020 01:54:15 -0400
Date: Fri, 17 Jul 2020 08:54:01 +0300
Message-Id: <83k0z2k7pi.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: gdb-patches@sourceware.org, Alan.Hayward@arm.com,
 catalin.marinas@arm.com, david.spickett@linaro.org
In-Reply-To: <20200715194513.16641-8-luis.machado@linaro.org> (message from
 Luis Machado via Gdb-patches on Wed, 15 Jul 2020 16:44:57 -0300)
Subject: Re: [PATCH 07/23] Documentation for memory tagging remote packets
References: <20200715194513.16641-1-luis.machado@linaro.org>
 <20200715194513.16641-8-luis.machado@linaro.org>
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2020 05:54:19 -0000

> Date: Wed, 15 Jul 2020 16:44:57 -0300
> From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
> Cc: catalin.marinas@arm.com, david.spickett@linaro.org
> 
> +If the number of memory tags, @var{N}, is greater than or equal to the number
> +of memory tag granules, @var{G}, only @var{G} tags will be stored.
> +
> +If @var{N} is less than @var{G}, the behavior is that of a fill operation,
> +and the tag bytes will be used as a pattern that will get repeated until
> +@var{G} tags are stored.

The symbols inside @var should be lower-case, per our conventions.
They look better in the printed manual that way.

> +For AArch64 GNU/Linux systems, this feature also requires access to the smaps
> +file in the proc filesystem so memory mapping page flags can be inspected.

"proc" should have the @file markup (and should probably be "/proc"?).

The patch is OK with those nits fixed.

Thanks.