[PATCH v5 20/25] New memory-tag commands

Luis Machado via Gdb-patches
2021-01-27T20:22:02Z

Updates on v5:

- Remove check for memory_tagging global.

Updates on v4:

- Update command names and function names.
- Moved common functions to gdbsupport/common-utils.cc.

--

Add new commands under the "memory-tag" prefix to allow users to inspect,
modify and check memory tags in different ways.

The available subcommands are the following:

- memory-tag print-logical-tag <expression>: Prints the logical tag for a
particular address.

- memory-tag withltag <expression> <tag>: Prints the address tagged with the
logical tag <tag>.

- memory-tag print-allocation-tag <expression>: Prints the allocation tag for
a particular address.

- memory-tag setatag <expression> <length> <tags>: Sets one or more allocation
tags to the specified tags.

- memory-tag check <expression>: Checks if the logical tag in
matches its allocation tag.

These commands make use of the memory tagging gdbarch methods, and are still
available, but disabled, when memory tagging is not supported by the
architecture.

I've pondered about a way to make these commands invisible when memory tagging
is not available, but given the check is at runtime (and support may come and go
based on a process' configuration), that is a bit too late in the process to
either not include the commands or get rid of them.

Ideas are welcome.

gdb/ChangeLog:

YYYY-MM-DD Luis Machado <luis.machado@linaro.org>

* printcmd.c: Include gdbsupport/rsp-low.h.
(memory_tag_list): New static global.
(process_print_command_args): Factored out of
print_command_1.
(print_command_1): Use process_print_command_args.
(show_addr_not_tagged, show_memory_tagging_unsupported)
(memory_tag_command, memory_tag_print_tag_command)
(memory_tag_print_logical_tag_command)
(memory_tag_print_allocation_tag_command, parse_with_logical_tag_input)
(memory_tag_with_logical_tag_command, parse_set_allocation_tag_input)
(memory_tag_set_allocation_tag_command, memory_tag_check_command): New
functions.
(_initialize_printcmd): Add "memory-tag" prefix and subcommands.

gdbsupport/ChangeLog:

YYYY-MM-DD Luis Machado <luis.machado@linaro.org>

* rsp-low.cc (fromhex, hex2bin): Move to ...
* common-utils.cc: ... here.
(fromhex) Change error message text to not be RSP-specific.
* rsp-low.h (fromhex, hex2bin): Move to ...
* common-utils.h: ... here.
---
gdb/printcmd.c | 364 +++++++++++++++++++++++++++++++++++--
gdbsupport/common-utils.cc | 49 +++++
gdbsupport/common-utils.h | 15 ++
gdbsupport/rsp-low.cc | 49 -----
gdbsupport/rsp-low.h | 19 --
5 files changed, 416 insertions(+), 80 deletions(-)

diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index 2e56d28e9f..78acda4e37 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -54,6 +54,11 @@
#include "gdbsupport/byte-vector.h"
#include "gdbsupport/gdb_optional.h"
#include "safe-ctype.h"
+#include "gdbsupport/rsp-low.h"
+
+/* Chain containing all defined memory-tag subcommands. */
+
+static struct cmd_list_element *memory_tag_list;

/* Last specified output format. */

@@ -1203,21 +1208,19 @@ print_value (value *val, const value_print_options &opts)
annotate_value_history_end ();
}

-/* Implementation of the "print" and "call" commands. */
+/* Helper for parsing arguments for print_command_1. */

-static void
-print_command_1 (const char *args, bool voidprint)
+static struct value *
+process_print_command_args (const char *args, value_print_options *print_opts,
+ bool voidprint)
{
- struct value *val;
- value_print_options print_opts;
-
- get_user_print_options (&print_opts);
+ get_user_print_options (print_opts);
/* Override global settings with explicit options, if any. */
- auto group = make_value_print_options_def_group (&print_opts);
+ auto group = make_value_print_options_def_group (print_opts);
gdb::option::process_options
(&args, gdb::option::PROCESS_OPTIONS_REQUIRE_DELIMITER, group);

- print_command_parse_format (&args, "print", &print_opts);
+ print_command_parse_format (&args, "print", print_opts);

const char *exp = args;

@@ -1226,10 +1229,20 @@ print_command_1 (const char *args, bool voidprint)
/* VOIDPRINT is true to indicate that we do want to print a void
value, so invert it for parse_expression. */
expression_up expr = parse_expression (exp, nullptr, !voidprint);
- val = evaluate_expression (expr.get ());
+ return evaluate_expression (expr.get ());
}
- else
- val = access_value_history (0);
+
+ return access_value_history (0);
+}
+
+/* Implementation of the "print" and "call" commands. */
+
+static void
+print_command_1 (const char *args, int voidprint)
+{
+ value_print_options print_opts;
+
+ struct value *val = process_print_command_args (args, &print_opts, voidprint);

if (voidprint || (val && value_type (val) &&
value_type (val)->code () != TYPE_CODE_VOID))
@@ -2780,6 +2793,274 @@ eval_command (const char *arg, int from_tty)
execute_command (expanded.c_str (), from_tty);
}

+/* Convenience function for error checking in memory-tag commands. */
+
+static void
+show_addr_not_tagged (CORE_ADDR address)
+{
+ error (_("Address %s not in a region mapped with a memory tagging flag."),
+ paddress (target_gdbarch (), address));
+}
+
+/* Convenience function for error checking in memory-tag commands. */
+
+static void
+show_memory_tagging_unsupported (void)
+{
+ error (_("Memory tagging not supported or disabled by the current"
+ " architecture."));
+}
+
+/* Implement the "memory-tag" prefix command. */
+
+static void
+memory_tag_command (const char *arg, int from_tty)
+{
+ help_list (memory_tag_list, "memory-tag ", all_commands, gdb_stdout);
+}
+
+/* Helper for print-logical-tag and print-allocation-tag. */
+
+static void
+memory_tag_print_tag_command (const char *args, enum memtag_type tag_type)
+{
+ if (args == nullptr)
+ error_no_arg (_("address or pointer"));
+
+ /* Parse args into a value. If the value is a pointer or an address,
+ then fetch the logical or allocation tag. */
+ value_print_options print_opts;
+
+ struct value *val = process_print_command_args (args, &print_opts, true);
+
+ /* If the address is not in a region memory mapped with a memory tagging
+ flag, it is no use trying to access/manipulate its allocation tag.
+
+ It is OK to manipulate the logical tag though. */
+ if (tag_type == tag_allocation
+ && !gdbarch_tagged_address_p (target_gdbarch (), val))
+ show_addr_not_tagged (value_as_address (val));
+
+ std::string tag = gdbarch_memtag_to_string (target_gdbarch (),
+ val, tag_type);
+ if (tag.empty ())
+ printf_filtered (_("%s tag unavailable.\n"),
+ tag_type == tag_logical? "Logical" : "Allocation");
+
+ struct value *v_tag = process_print_command_args (tag.c_str (),
+ &print_opts,
+ true);
+ print_opts.output_format = 'x';
+ print_value (v_tag, print_opts);
+}
+
+/* Implement the "memory-tag print-logical-tag" command. */
+
+static void
+memory_tag_print_logical_tag_command (const char *args, int from_tty)
+{
+ if (!target_supports_memory_tagging ())
+ show_memory_tagging_unsupported ();
+
+ memory_tag_print_tag_command (args, tag_logical);
+}
+
+/* Implement the "memory-tag print-allocation-tag" command. */
+
+static void
+memory_tag_print_allocation_tag_command (const char *args, int from_tty)
+{
+ if (!target_supports_memory_tagging ())
+ show_memory_tagging_unsupported ();
+
+ memory_tag_print_tag_command (args, tag_allocation);
+}
+
+/* Parse ARGS and extract ADDR and TAG.
+ ARGS should have format <expression> <tag bytes>. */
+
+static void
+parse_with_logical_tag_input (const char *args, struct value **val,
+ gdb::byte_vector &tags,
+ value_print_options *print_opts)
+{
+ /* Fetch the address. */
+ std::string address_string = extract_string_maybe_quoted (&args);
+
+ /* Parse the address into a value. */
+ *val = process_print_command_args (address_string.c_str (), print_opts,
+ true);
+
+ /* Fetch the tag bytes. */
+ std::string tag_string = extract_string_maybe_quoted (&args);
+
+ /* Validate the input. */
+ if (address_string.empty () || tag_string.empty ())
+ error (_("Missing arguments."));
+
+ if (tag_string.length () != 2)
+ error (_("Error parsing tags argument. The tag should be 2 digits."));
+
+ tags = hex2bin (tag_string.c_str ());
+}
+
+/* Implement the "memory-tag with-logical-tag" command. */
+
+static void
+memory_tag_with_logical_tag_command (const char *args, int from_tty)
+{
+ if (!target_supports_memory_tagging ())
+ show_memory_tagging_unsupported ();
+
+ if (args == nullptr)
+ error_no_arg (_(" <tag>"));
+
+ gdb::byte_vector tags;
+ struct value *val;
+ value_print_options print_opts;
+
+ /* Parse the input. */
+ parse_with_logical_tag_input (args, &val, tags, &print_opts);
+
+ /* Setting the logical tag is just a local operation that does not touch
+ any memory from the target. Given an input value, we modify the value
+ to include the appropriate tag.
+
+ For this reason we need to cast the argument value to a
+ (void *) pointer. This is so we have the right type for the gdbarch
+ hook to manipulate the value and insert the tag.
+
+ Otherwise, this would fail if, for example, GDB parsed the argument value
+ into an int-sized value and the pointer value has a type of greater
+ length. */
+
+ /* Cast to (void *). */
+ val = value_cast (builtin_type (target_gdbarch ())->builtin_data_ptr,
+ val);
+
+ if (!gdbarch_set_memtags (target_gdbarch (), val, 0, tags,
+ tag_logical))
+ printf_filtered (_("Could not update the logical tag data.\n"));
+ else
+ {
+ /* Always print it in hex format. */
+ print_opts.output_format = 'x';
+ print_value (val, print_opts);
+ }
+}
+
+/* Parse ARGS and extract ADDR, LENGTH and TAGS. */
+
+static void
+parse_set_allocation_tag_input (const char *args, struct value **val,
+ size_t *length, gdb::byte_vector &tags)
+{
+ /* Fetch the address. */
+ std::string address_string = extract_string_maybe_quoted (&args);
+
+ /* Parse the address into a value. */
+ value_print_options print_opts;
+ *val = process_print_command_args (address_string.c_str (), &print_opts,
+ true);
+
+ /* Fetch the length. */
+ std::string length_string = extract_string_maybe_quoted (&args);
+
+ /* Fetch the tag bytes. */
+ std::string tags_string = extract_string_maybe_quoted (&args);
+
+ /* Validate the input. */
+ if (address_string.empty () || length_string.empty () || tags_string.empty ())
+ error (_("Missing arguments."));
+
+ errno = 0;
+ *length = strtoulst (length_string.c_str (), NULL, 10);
+ if (errno != 0)
+ error (_("Error parsing length argument."));
+
+ if (tags_string.length () % 2)
+ error (_("Error parsing tags argument. Tags should be 2 digits per byte."));
+
+ tags = hex2bin (tags_string.c_str ());
+
+ /* If the address is not in a region memory mapped with a memory tagging
+ flag, it is no use trying to access/manipulate its allocation tag. */
+ if (!gdbarch_tagged_address_p (target_gdbarch (), *val))
+ show_addr_not_tagged (value_as_address (*val));
+}
+
+/* Implement the "memory-tag set-allocation-tag" command.
+ ARGS should be in the format <length> <tags>. */
+
+static void
+memory_tag_set_allocation_tag_command (const char *args, int from_tty)
+{
+ if (!target_supports_memory_tagging ())
+ show_memory_tagging_unsupported ();
+
+ if (args == nullptr)
+ error_no_arg (_("<starting address> <length> <tag bytes>"));
+
+ gdb::byte_vector tags;
+ size_t length = 0;
+ struct value *val;
+
+ /* Parse the input. */
+ parse_set_allocation_tag_input (args, &val, &length, tags);
+
+ if (!gdbarch_set_memtags (target_gdbarch (), val, length, tags,
+ tag_allocation))
+ printf_filtered (_("Could not update the allocation tag(s).\n"));
+ else
+ printf_filtered (_("Allocation tag(s) updated successfully.\n"));
+}
+
+/* Implement the "memory-tag check" command. */
+
+static void
+memory_tag_check_command (const char *args, int from_tty)
+{
+ if (!target_supports_memory_tagging ())
+ show_memory_tagging_unsupported ();
+
+ if (args == nullptr)
+ error (_("Argument required (address or pointer)"));
+
+ /* Parse the expression into a value. If the value is an address or
+ pointer, then check its logical tag against the allocation tag. */
+ value_print_options print_opts;
+
+ struct value *val = process_print_command_args (args, &print_opts, true);
+
+ /* If the address is not in a region memory mapped with a memory tagging
+ flag, it is no use trying to access/manipulate its allocation tag. */
+ if (!gdbarch_tagged_address_p (target_gdbarch (), val))
+ show_addr_not_tagged (value_as_address (val));
+
+ CORE_ADDR addr = value_as_address (val);
+
+ /* Check if the tag is valid. */
+ if (!gdbarch_memtag_matches_p (target_gdbarch (), val))
+ {
+ std::string ltag = gdbarch_memtag_to_string (target_gdbarch (),
+ val, tag_logical);
+ std::string atag = gdbarch_memtag_to_string (target_gdbarch (),
+ val, tag_allocation);
+
+ printf_filtered (_("Logical tag (%s) does not match"
+ " the allocation tag (%s) for address %s.\n"),
+ ltag.c_str (), atag.c_str (),
+ paddress (target_gdbarch (), addr));
+ }
+ else
+ {
+ std::string ltag = gdbarch_memtag_to_string (target_gdbarch (),
+ val, tag_logical);
+ printf_filtered (_("Memory tags for address %s match (%s).\n"),
+ paddress (target_gdbarch (), addr), ltag.c_str ());
+ }
+}
+
void _initialize_printcmd ();
void
_initialize_printcmd ()
@@ -2982,4 +3263,63 @@ Construct a GDB command and then evaluate it.\n\
Usage: eval \"format string\", ARG1, ARG2, ARG3, ..., ARGN\n\
Convert the arguments to a string as \"printf\" would, but then\n\
treat this string as a command line, and evaluate it."));
+
+ /* Memory tagging commands. */
+ add_prefix_cmd ("memory-tag", class_vars, memory_tag_command, _("\
+Generic command for printing and manipulating memory tag properties."),
+ &memory_tag_list, "memory-tag ", 0, &cmdlist);
+ add_cmd ("print-logical-tag", class_vars,
+ memory_tag_print_logical_tag_command,
+ ("Print the logical tag for an address.\n\
+Usage: memory-tag print-logical-tag .\n\
+ is an expression that evaluates to a pointer or memory address.\n\
+GDB will print the logical tag associated with . The tag\n\
+interpretation is architecture-specific."),
+ &memory_tag_list);
+ add_cmd ("print-allocation-tag", class_vars,
+ memory_tag_print_allocation_tag_command,
+ _("Print the allocation tag for an address.\n\
+Usage: memory-tag print-allocation-tag .\n\
+ is an expression that evaluates to a pointer or memory address.\n\
+GDB will print the allocation tag associated with . The tag\n\
+interpretation is architecture-specific."),
+ &memory_tag_list);
+ add_cmd ("with-logical-tag", class_vars, memory_tag_with_logical_tag_command,
+ _("Set the logical tag for an address.\n\
+Usage: memory-tag with-logical-tag <tag>\n\
+ is an expression that evaluates to a pointer or memory address.\n\
+<tag> is a sequence of hex bytes that will be interpreted by the\n\
+architecture as a single memory tag.\n\
+GDB will set the logical tag for to <tag>, and will print the\n\
+resulting address with the updated tag."),
+ &memory_tag_list);
+ add_cmd ("set-allocation-tag", class_vars,
+ memory_tag_set_allocation_tag_command,
+ _("Set the allocation tag for an address.\n\
+Usage: memory-tag set-allocation-tag <length> <tag_bytes>\n\
+ is an expression that evaluates to a pointer or memory address\n\
+<length> is the number of bytes that will get added to to calculate\n\
+the memory range.\n\
+<tag bytes> is a sequence of hex bytes that will be interpreted by the\n\
+architecture as one or more memory tags.\n\
+Sets the tags of the memory range [ , + <length>)\n\
+to the specified tag bytes.\n\
+\n\
+If the number of tags is greater than or equal to the number of tag granules\n\
+in the [ , + <length) range, only the tags up to the\n\
+number of tag granules will be stored.\n\
+\n\
+If the number of tags is less than the number of tag granules, then the\n\
+command is a fill operation. The tag bytes are interpreted as a pattern\n\
+that will get repeated until the number of tag granules in the memory range\n\
+[ , + <length>] is stored to."),
+ &memory_tag_list);
+ add_cmd ("check", class_vars, memory_tag_check_command,
+ _("Validate the logical tag against the allocation tag.\n\
+Usage: memory-tag check \n\
+ is an expression that evaluates to a pointer or memory address\n\
+GDB will fetch the logical and allocation tags for and will\n\
+compare them for equality. If the tags do not match, GDB will show\n\
+additional information about the mismatch."),
+ &memory_tag_list);
}
diff --git a/gdbsupport/common-utils.cc b/gdbsupport/common-utils.cc
index ed3348057c..8ce839a54a 100644
--- a/gdbsupport/common-utils.cc
+++ b/gdbsupport/common-utils.cc
@@ -392,3 +392,52 @@ align_down (ULONGEST v, int n)
gdb_assert (n && (n & (n-1)) == 0);
return (v & -n);
}
+
+/* See gdbsupport/common-utils.h. */
+
+int
+fromhex (int a)
+{
+ if (a >= '0' && a <= '9')
+ return a - '0';
+ else if (a >= 'a' && a <= 'f')
+ return a - 'a' + 10;
+ else if (a >= 'A' && a <= 'F')
+ return a - 'A' + 10;
+ else
+ error (_("Invalid hex digit %d"), a);
+}
+
+/* See gdbsupport/common-utils.h. */
+
+int
+hex2bin (const char *hex, gdb_byte *bin, int count)
+{
+ int i;
+
+ for (i = 0; i < count; i++)
+ {
+ if (hex[0] == 0 || hex[1] == 0)
+ {
+ /* Hex string is short, or of uneven length.
+ Return the count that has been converted so far. */
+ return i;
+ }
+ *bin++ = fromhex (hex[0]) * 16 + fromhex (hex[1]);
+ hex += 2;
+ }
+ return i;
+}
+
+/* See gdbsupport/common-utils.h. */
+
+gdb::byte_vector
+hex2bin (const char *hex)
+{
+ size_t bin_len = strlen (hex) / 2;
+ gdb::byte_vector bin (bin_len);
+
+ hex2bin (hex, bin.data (), bin_len);
+
+ return bin;
+}
diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h
index 4429f086fc..cad20d8899 100644
--- a/gdbsupport/common-utils.h
+++ b/gdbsupport/common-utils.h
@@ -22,6 +22,7 @@

#include <string>
#include <vector>
+#include "gdbsupport/byte-vector.h"

#include "poison.h"

@@ -195,4 +196,18 @@ in_inclusive_range (T value, T low, T high)
extern ULONGEST align_up (ULONGEST v, int n);
extern ULONGEST align_down (ULONGEST v, int n);

+/* Convert hex digit A to a number, or throw an exception. */
+extern int fromhex (int a);
+
+/* HEX is a string of characters representing hexadecimal digits.
+ Convert pairs of hex digits to bytes and store sequentially into
+ BIN. COUNT is the maximum number of characters to convert. This
+ will convert fewer characters if the number of hex characters
+ actually seen is odd, or if HEX terminates before COUNT characters.
+ Returns the number of characters actually converted. */
+extern int hex2bin (const char *hex, gdb_byte *bin, int count);
+
+/* Like the above, but return a gdb::byte_vector. */
+gdb::byte_vector hex2bin (const char *hex);
+
#endif /* COMMON_COMMON_UTILS_H */
diff --git a/gdbsupport/rsp-low.cc b/gdbsupport/rsp-low.cc
index eb8f70a305..8900ed4fc0 100644
--- a/gdbsupport/rsp-low.cc
+++ b/gdbsupport/rsp-low.cc
@@ -22,21 +22,6 @@

/* See rsp-low.h. */

-int
-fromhex (int a)
-{
- if (a >= '0' && a <= '9')
- return a - '0';
- else if (a >= 'a' && a <= 'f')
- return a - 'a' + 10;
- else if (a >= 'A' && a <= 'F')
- return a - 'A' + 10;
- else
- error (_("Reply contains invalid hex digit %d"), a);
-}
-
-/* See rsp-low.h. */
-
int
tohex (int nib)
{
@@ -111,40 +96,6 @@ unpack_varlen_hex (const char *buff, /* packet to parse */

/* See rsp-low.h. */

-int
-hex2bin (const char *hex, gdb_byte *bin, int count)
-{
- int i;
-
- for (i = 0; i < count; i++)
- {
- if (hex[0] == 0 || hex[1] == 0)
- {
- /* Hex string is short, or of uneven length.
- Return the count that has been converted so far. */
- return i;
- }
- *bin++ = fromhex (hex[0]) * 16 + fromhex (hex[1]);
- hex += 2;
- }
- return i;
-}
-
-/* See rsp-low.h. */
-
-gdb::byte_vector
-hex2bin (const char *hex)
-{
- size_t bin_len = strlen (hex) / 2;
- gdb::byte_vector bin (bin_len);
-
- hex2bin (hex, bin.data (), bin_len);
-
- return bin;
-}
-
-/* See rsp-low.h. */
-
std::string
hex2str (const char *hex)
{
diff --git a/gdbsupport/rsp-low.h b/gdbsupport/rsp-low.h
index fd0b16f158..6ef4b36a1d 100644
--- a/gdbsupport/rsp-low.h
+++ b/gdbsupport/rsp-low.h
@@ -20,12 +20,6 @@
#ifndef COMMON_RSP_LOW_H
#define COMMON_RSP_LOW_H

-#include "gdbsupport/byte-vector.h"
-
-/* Convert hex digit A to a number, or throw an exception. */
-
-extern int fromhex (int a);
-
/* Convert number NIB to a hex digit. */

extern int tohex (int nib);
@@ -45,19 +39,6 @@ extern char *pack_hex_byte (char *pkt, int byte);

extern const char *unpack_varlen_hex (const char *buff, ULONGEST *result);

-/* HEX is a string of characters representing hexadecimal digits.
- Convert pairs of hex digits to bytes and store sequentially into
- BIN. COUNT is the maximum number of characters to convert. This
- will convert fewer characters if the number of hex characters
- actually seen is odd, or if HEX terminates before COUNT characters.
- Returns the number of characters actually converted. */
-
-extern int hex2bin (const char *hex, gdb_byte *bin, int count);
-
-/* Like the above, but return a gdb::byte_vector. */
-
-gdb::byte_vector hex2bin (const char *hex);
-
/* Like hex2bin, but return a std::string. */

extern std::string hex2str (const char *hex);
--
2.25.1