From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZFPdH4dCZmRrqA0AWB0awg (envelope-from ) for ; Thu, 18 May 2023 11:21:43 -0400 Received: by simark.ca (Postfix, from userid 112) id 74BB41E11E; Thu, 18 May 2023 11:21:43 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CZ6F51U+; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F9631E111 for ; Thu, 18 May 2023 11:21:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AF623853839 for ; Thu, 18 May 2023 15:21:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AF623853839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684423296; bh=HHPFE+6vPLyE/7fmpbEDCqYQeOH1Ob8KKOzc2O5BADM=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CZ6F51U+y3XmjFu2TQu9Ib7riMKgNxwR4JUDqAeaeBIG3WpRVHOUZrjZ8HfX4pFSG AcnzW9bIupCQWKY59YBTD0v1xIuVcMDzd2pqg4kcJvifnoYwNXrdjRxSMr9dxUkdrM fQawrbIWHF6ybGQj4CQdgp5B5z+BuwpTCvJ7YyKg= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7C250385354A for ; Thu, 18 May 2023 15:19:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C250385354A Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfPu-0002Rp-7h; Thu, 18 May 2023 11:19:46 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfPt-0007fz-FC; Thu, 18 May 2023 11:19:45 -0400 Date: Thu, 18 May 2023 18:19:58 +0300 Message-Id: <83jzx5vf8h.fsf@gnu.org> To: Simon Farre Cc: gdb-patches@sourceware.org In-Reply-To: <20230518144552.67097-1-simon.farre.cx@gmail.com> (message from Simon Farre via Gdb-patches on Thu, 18 May 2023 16:45:52 +0200) Subject: Re: [PATCH v2] [gdb/infcmd]: Add next-expression command References: <20230518144552.67097-1-simon.farre.cx@gmail.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Cc: Simon Farre > Date: Thu, 18 May 2023 16:45:52 +0200 > From: Simon Farre via Gdb-patches > > gdb/NEWS | 7 ++++ > gdb/buildsym-legacy.c | 4 +- > gdb/buildsym-legacy.h | 2 +- > gdb/buildsym.c | 3 +- > gdb/buildsym.h | 4 +- > gdb/coffread.c | 4 +- > gdb/dbxread.c | 6 +-- > gdb/doc/gdb.texinfo | 16 +++++++- > gdb/doc/python.texi | 6 +++ > gdb/dwarf2/read.c | 32 ++++++++++----- > gdb/gdbthread.h | 2 + > gdb/infcmd.c | 91 +++++++++++++++++++++++++++++++++++------- > gdb/infrun.c | 8 ++++ > gdb/mdebugread.c | 2 +- > gdb/python/py-symtab.c | 29 ++++++++++---- > gdb/stack.c | 7 ++++ > gdb/symtab.c | 1 + > gdb/symtab.h | 22 ++++++++++ > 18 files changed, 201 insertions(+), 45 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index b82114d80b0..38c6f54564b 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,13 @@ > > *** Changes since GDB 13 > > +* New commmand "next-expression" ("ne") that steps by expression or statement > + on a single source line if debug information is available. > + > +* New column attribute of Python type Symtab_and_line to reflect the added > + column field on "linetable_entry". Describes what column on the source line ^^ Two spaces there. > + that is being executed. Columns are byte-level coordinates on a source line. ^^ And there. > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -5899,6 +5899,12 @@ Indicates the current line number for this object. This > attribute is not writable. > @end defvar > > +@defvar Symtab_and_line.column > +Indicates the current column number for this object. This > +attribute is not writeable. A source-line column is it's byte position ^^^^ "its', not "it's". Reviewed-By: Eli Zaretskii