From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31352 invoked by alias); 27 Nov 2011 16:35:12 -0000 Received: (qmail 30689 invoked by uid 22791); 27 Nov 2011 16:35:07 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Nov 2011 16:34:51 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LVB00M00V3E4D00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sun, 27 Nov 2011 18:34:48 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.205.148]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LVB00KYVVDZWKJ0@a-mtaout22.012.net.il>; Sun, 27 Nov 2011 18:34:48 +0200 (IST) Date: Sun, 27 Nov 2011 16:35:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings In-reply-to: <201111271352.pARDqjCg025404@glazunov.sibelius.xs4all.nl> To: Mark Kettenis Cc: brobecker@adacore.com, andrew.smirnov@gmail.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ipm57ccy.fsf@gnu.org> References: <201111231640.pANGefc4031803@d06av02.portsmouth.uk.ibm.com> <201111231820.40486.pedro@codesourcery.com> <201111232023.pANKNcLf022983@glazunov.sibelius.xs4all.nl> <20111124220057.GU13809@adacore.com> <83hb1s8l5c.fsf@gnu.org> <201111251511.pAPFBBkP007292@glazunov.sibelius.xs4all.nl> <83ehww8b1t.fsf@gnu.org> <201111251626.pAPGQ3rN016558@glazunov.sibelius.xs4all.nl> <83aa7k83p0.fsf@gnu.org> <201111271352.pARDqjCg025404@glazunov.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00735.txt.bz2 > Date: Sun, 27 Nov 2011 14:52:45 +0100 (CET) > From: Mark Kettenis > CC: brobecker@adacore.com, andrew.smirnov@gmail.com, > gdb-patches@sourceware.org > > > Date: Fri, 25 Nov 2011 20:19:55 +0200 > > From: Eli Zaretskii > > > > > Date: Fri, 25 Nov 2011 17:26:04 +0100 (CET) > > > From: Mark Kettenis > > > CC: brobecker@adacore.com, andrew.smirnov@gmail.com, > > > gdb-patches@sourceware.org > > > > > > Since there is absolutely no problem with a local variable that has > > > the same name as a library function, this is bad. > > > > You are, in effect, saying that the wisdom of coding "down the middle > > of a programming language" is wrong. We will have to disagree on > > that, sorry. FWIW, I don't think a large project should live > > dangerously just because some versions of some compiler will flag > > these clashes even without -Wshadow. > > I think you're still missing my point. No, I'm not. I understood perfectly what you are saying. We just don't agree on whether having local variables by the name of an external function is or isn't a practice to be avoided.