From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85989-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26797 invoked by alias); 9 Dec 2011 19:11:02 -0000
Received: (qmail 26776 invoked by uid 22791); 9 Dec 2011 19:11:01 -0000
X-SWARE-Spam-Status: No, hits=-0.9 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 19:10:36 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LVY00400AC5XT00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Dec 2011 21:10:22 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.156.225]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LVY004T3AL99GF0@a-mtaout20.012.net.il>; Fri, 09 Dec 2011 21:10:22 +0200 (IST)
Date: Fri, 09 Dec 2011 19:23:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode
In-reply-to: <201112091630.20916.pedro@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: jan.kratochvil@redhat.com, gingold@adacore.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iplpmuht.fsf@gnu.org>
References: <201112051601.59664.pedro@codesourcery.com> <20111205202513.GA26929@host2.jankratochvil.net> <201112091630.20916.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00308.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 9 Dec 2011 16:30:20 +0000
> Cc: gdb-patches@sourceware.org
> 
> On Monday 05 December 2011 16:01:02, Pedro Alves wrote:
> > I have tested this on x86_64-linux (-m64|-m32), which showed no
> > regressions.  The patch also adjusts all other users of i396-nat.c:
> > djgpp/go32; i386 BSDs (FreeBSD only it seems); Windows (cygwin/mingw)
> > and macosx (darwin), but I haven't tested those.  I'd appreciate
> > testing or an extra pair of eyes.
> > 
> > Actually darwin has the i386 watchpoint hooks in place, but it doesn't
> > install them:
> > 
> >  $ grep i386_darwin_dr_get_status *
> >  i386-darwin-nat.c:i386_darwin_dr_get_status (void)
> >  $
> > 
> > ??
> 
> Anyone want to comment on those platform bits?

My extra pair of eyes spotted this:

> --- a/gdb/go32-nat.c
> +++ b/gdb/go32-nat.c
> @@ -801,6 +801,28 @@ go32_get_dr6 (void)
>    return STATUS;
>  }
>  
> +/* Get the value of the DR6 debug status register from the inferior.
> +   Here we just return the value stored in D_REGS, as we've got it
> +   from the last go32_wait call.  */
> +static unsigned long
> +go32_get_dr7 (void)
> +{
> +  return CONTROL;
> +}

The comment says DR6, but the function uses dr7.  I think the comment
is wrong.

No other comments.  Thanks.