From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98974-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30559 invoked by alias); 2 Mar 2013 07:30:06 -0000
Received: (qmail 30535 invoked by uid 22791); 2 Mar 2013 07:30:04 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Mar 2013 07:29:55 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MJ000B00VEIZ400@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 02 Mar 2013 09:29:54 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJ000BW9VHPYU00@a-mtaout20.012.net.il>; Sat, 02 Mar 2013 09:29:50 +0200 (IST)
Date: Sat, 02 Mar 2013 07:30:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Constify find_condition_and_thread
In-reply-to: <87vc9aud7p.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: palves@redhat.com, keiths@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ip5auun3.fsf@gnu.org>
References: <5130F0FD.2040203@redhat.com> <83ppzjufp5.fsf@gnu.org> <5130F9BB.6020002@redhat.com> <87vc9aud7p.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00050.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Keith Seitz <keiths@redhat.com>,        gdb-patches@sourceware.org
> Date: Fri, 01 Mar 2013 12:33:46 -0700
> 
> I think the problem is that the parsers probably do modify the input
> string.  So, you couldn't pass in a readonly string.

I figured that much.  But if that's the problem, perhaps the caller
should xstrdup the original string and pass a modifiable one to its
callees, instead of forcing low-level subroutines do that.