Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Blanc, Nicolas" <nicolas.blanc@intel.com>
Cc: gdb-patches@sourceware.org, lgustavo@codesourcery.com
Subject: Re: [PATCH v10 3/5] Documentation for the remove-symbol-file command.
Date: Tue, 25 Jun 2013 15:13:00 -0000	[thread overview]
Message-ID: <83ip12i657.fsf@gnu.org> (raw)
In-Reply-To: <388084C8C1E6A64FA36AD1D656E485661A7A6C32@IRSMSX106.ger.corp.intel.com>

> From: "Blanc, Nicolas" <nicolas.blanc@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
> 	"lgustavo@codesourcery.com" <lgustavo@codesourcery.com>
> Date: Tue, 25 Jun 2013 09:13:35 +0000
> 
> 
> >>  The symbol table of the file @var{filename} is added to the symbol 
> >> table  originally read with the @code{symbol-file} command.  You can 
> >> use the  @code{add-symbol-file} command any number of times; the new 
> >> symbol data -thus read keeps adding to the old.  To discard all old 
> >> symbol data -instead, use the @code{symbol-file} command without any arguments.
> >> +thus read keeps adding to the old.
> >             ^^^^^^^^^^^^^^^^^^^^^^^
> > I guess you meant "is kept in addition to the old", right?
> >
> > Thanks.
> 
> This sentence "the new symbol data thus read keeps adding to the old." is original.
> I removed the next one on the same line. "keeps adding" sounds ok
> to my ears but I am not a native speaker. So I'll follow your recommendation.
> Should I change the sentence?

Yes, please.


  reply	other threads:[~2013-06-25 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24  8:36 [PATCH v10 0/5] remove-symbol-file & add-symbol-file Nicolas Blanc
2013-06-24  8:36 ` [PATCH v10 3/5] Documentation for the remove-symbol-file command Nicolas Blanc
2013-06-24 16:39   ` Eli Zaretskii
2013-06-25  9:39     ` Blanc, Nicolas
2013-06-25 15:13       ` Eli Zaretskii [this message]
2013-06-24  8:36 ` [PATCH v10 2/5] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-06-24  8:36 ` [PATCH v10 1/5] New remove-symbol-file command Nicolas Blanc
2013-06-24  8:36 ` [PATCH v10 5/5] Test 'info files' after 'add-symbol-file' and 'remove-symbol-file' Nicolas Blanc
2013-06-24 11:33 ` [PATCH v10 4/5] 'add-symbol-file' should update the current target sections Nicolas Blanc
2013-06-24 12:56 ` [PATCH v10 0/5] remove-symbol-file & add-symbol-file Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ip12i657.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=nicolas.blanc@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox