From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14770 invoked by alias); 19 May 2014 15:01:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14751 invoked by uid 89); 19 May 2014 15:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout25.012.net.il Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 15:01:20 +0000 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N5T00500TIN3100@mtaout25.012.net.il> for gdb-patches@sourceware.org; Mon, 19 May 2014 17:58:13 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5T005JCTL11500@mtaout25.012.net.il>; Mon, 19 May 2014 17:58:13 +0300 (IDT) Date: Mon, 19 May 2014 15:01:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 2/2 v2] Demangler crash handler In-reply-to: <20140519114801.GA31140@blade.nx> To: Gary Benson Cc: gdb-patches@sourceware.org, aburgess@broadcom.com, xdje42@gmail.com, fw@deneb.enyo.de, mark.kettenis@xs4all.nl, palves@redhat.com, tromey@redhat.com Reply-to: Eli Zaretskii Message-id: <83iop1dd8e.fsf@gnu.org> References: <20140519114801.GA31140@blade.nx> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00352.txt.bz2 > Date: Mon, 19 May 2014 12:48:02 +0100 > From: Gary Benson > Cc: Andrew Burgess , Doug Evans , > Eli Zaretskii , Florian Weimer , > Mark Kettenis , > Pedro Alves , Tom Tromey > > The main change I have made is to cause the crash handler to be > disabled by default. The user must explicitly enable the handler > with "maint set catch-demangler-crashes on". This will simplify > triage of bugs such as PR 16957 [2], a new demangler crash that was > reported on Friday. The user did not supply enough information to > see the offending symbol, and I don't have the necessary compiler > or libraries to reproduce the bug locally. With this patch we can > instruct the user to enter "maint set catch-demangler-crashes on" > and repeat whatever they did to cause the crash in the first place. > We can then easily obtain the first offending symbol GDB encountered. Can't say this option makes sense to me. Isn't there a way to display the necessary information in a message, even though you catch the signal? > maint set catch-demangler-crashes (on|off) > maint show catch-demangler-crashes > Control whether the debugger should attempt to catch crashes in the > symbol name demangler. The default is not to attempt to catch > crashes. The first time a crash is caught the offending symbol is > displayed and the user is presented with options to terminate the > current session and/or to create a core file. Given this description, it sounds like all the necessary information is already displayed when the crash is caught. So why would we need an option? > gdb/doc/ > 2014-05-19 Gary Benson > > * gdb.texinfo (Maintenance Commands): Document new > "maint set/show catch-demangler-crashes" option. This part of the patch was absent from what you sent. > +#ifdef SIGSEGV AFAIK, SIGSEGV is an ANSI-standard signal, so I don't think you need a preprocessor conditional here. > + add_setshow_boolean_cmd ("catch-demangler-crashes", class_maintenance, > + &catch_demangler_crashes, _("\ > +Set whether to attempt to catch demangler crashes."), _("\ > +Show whether GDB will attempt to catch demangler crashes."), _("\ The "Set" and "Show" lines should be identical except for the initial word. Thanks.