Re: [ping] [PATCH] Different outputs affected by locale

Pedro Alves
2014-06-05T10:27:42Z

On 06/05/2014 10:56 AM, Yao Qi wrote:

> Yes, it is simple to pass env variable through ssh, but isn't trivial to
> pass env variable to host or target in dejagnu, because,
>
> - ssh is not the only connection dejagnu supports, how about telnet?

Well, nobody really uses that for _host_ connections.

> - env variable should bind to board. host and target can have
> different env vars.
>
> I saw Jie's patch to set env var on target
> http://lists.gnu.org/archive/html/dejagnu/2008-07/msg00000.html
> but we need do more than that, IMO. That is the reason I am inclined to
> fix the test case instead of the infrastructure (dejagnu).

In practice, all real host board files will have a ${board}_spawn
override anyway. We can set GDB's vars in a gdb_env array, similar
to Jie's patch, and then the ${board}_spawn routine can pass them
to $RSH. When/if Jie's patch is extended to bind to board, and
accepted upstream, we just set the appropriate new board var to $gdb_env.

--
Pedro Alves