Re: [ping] [PATCH] Different outputs affected by locale

Yao Qi
2014-06-05T03:31:31Z

On 06/05/2014 04:23 AM, Pedro Alves wrote:
>> > I am not really a great standards lawyer but my first reaction is that
>> > mingw's C locale is not conforming. At least from:
>> >
>> > http://pubs.opengroup.org/onlinepubs/009604499/basedefs/xbd_chap07.html
>> >
>> > .. it seems to me that \242 is not defined as a 'print' character in the
>> > LC_CTYPE section. Though I'd like to reiterate that I don't actually
>> > trust my own reading of that text.
> I wonder whether this is really a mingw issue, or whether this is a
> remote host testing issue. That is, aren't we setting LC_CTYPE
> on the _build_ (where expect runs), not on the host (mingw, through

This is a not a mingw issue nor a remote host testing issue. If the
LC_CTYPE isn't set properly on host, these tests will fail, even in the
native testing.

> ssh)? Is LC_CTYPE really being propagated to the host?

No, setting env variables on host or target in dejagnu isn't trivial to
me.

> Does testing GDB manually directly on a Windows console show the same
> issue?

Yes, here is the output I got on Windows 7 (running gdb.exe in Windows console).
However, I didn't investigate why 'Ã³' is printed.

gdb) p repeat
$1 = L"A", 'Ã³' <repeats 21 times>, "B\000\xffff\200\000\x1370\500\xfe0c\"\x300\x
7ffe\xfe98\"\xe115\x771b\x67c9\x42c8\xfffe\xffff\x6d91\x7726\x1ae0@\xeb0:\x300\x
7ffe\xea8:\200\000Î©\000\xf480\x7594\000:\000\000\xf489\x7594\017\000\004\000Î©\00
0\xfe9c\"\x6094\x771e\xa2ac\x771f\xffff\xffff$\000\xfe98\"\004\000\000\000\x559\
xc000\xfea8\"\xf600\x7594\000\000\000\000\000\000\xfebc\"\xa442\x7594\x2a8\x759e
\xfefc\"\xf4d2\x7594\b\000\x118e\x7595\x1162\x7595\x8ccb\x3e13\000\000\000\000\0
00\000\x1ae0@\xfed0\"\x8fe3\x759b\xffc4"

here is the update patch to match either \242 or cent sign.

--
Yao (é½å°§)

Subject: [PATCH] Different outputs affected by locale
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We find the following fails in gdb test on mingw host.

FAIL: gdb.base/wchar.exp: print repeat
FAIL: gdb.base/wchar.exp: print repeat_p
FAIL: gdb.base/wchar.exp: print repeat (print null on)
FAIL: gdb.base/wchar.exp: print repeat (print elements 3)
FAIL: gdb.base/wchar.exp: print repeat_p (print elements 3)

print repeat^M
$7 = L"A", 'Â¢' <repeats 21 times>, "B", '\000' <repeats 104 times>^M
(gdb) FAIL: gdb.base/wchar.exp: print repeat

the \242 is expected in the test but cent sign is displayed.

In valprint.c:print_wchar, wchar_printable is called to determine
whether a wchar is printable. wchar_printable calls iswprint but
the iswprint's return value depends on LC_CTYPE setting of locale [1, 2].
The output may vary with different locale settings. I noticed that
gdb.exp:gdb_init set LC_CTYPE to C. If I remove that line, tests
fail on native testing too.

IMO, either \242 or 'Â¢' (cent sign) is a correct output, which is
affect by locale, and it is not related to gdb at all.

[1] http://pubs.opengroup.org/onlinepubs/009604499/functions/iswprint.html
[2] http://msdn.microsoft.com/en-us/library/ewx8s4kw.aspx

This patch is extend $cent for cent sign to match in the tests.

gdb/testsuite:

2014-06-05 Yao Qi <yao@codesourcery.com>

* gdb.base/wchar.exp: Extend $cent to match cent sign.
---
gdb/testsuite/gdb.base/wchar.exp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/wchar.exp b/gdb/testsuite/gdb.base/wchar.exp
index 4290478..aa19d92 100644
--- a/gdb/testsuite/gdb.base/wchar.exp
+++ b/gdb/testsuite/gdb.base/wchar.exp
@@ -36,7 +36,10 @@ gdb_test "print simple\[2\]" "= 99 L'c'"

gdb_test "print difficile\[2\]" "= 65261 L'\\\\xfeed'"

-set cent "\\\\242"
+# The contents in 'repeat' are shown differently under different
+# locale. We match all the possible outputs here, '\242' or cent sign.
+set cent "(\\\\242|\u00A2)"
+
gdb_test "print repeat" "= L\"A\", '$cent' <repeats 21 times>, \"B.*"

global hex
--
1.9.0