Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Cleber Rosa <crosa@redhat.com>
Cc: gdb-patches@sourceware.org, areis@redhat.com
Subject: Re: [PATCH 3/4] GDBServer: introduce --server-stderr command line option
Date: Mon, 23 Mar 2015 19:12:00 -0000	[thread overview]
Message-ID: <83iodrr0j6.fsf@gnu.org> (raw)
In-Reply-To: <55105FFD.60204@redhat.com>

> Date: Mon, 23 Mar 2015 15:48:29 -0300
> From: Cleber Rosa <crosa@redhat.com>
> CC: gdb-patches@sourceware.org, areis@redhat.com
> 
> >> +@item --server-stderr
> >> +Instruct @code{gdbserver} to redirect its own @code{stderr} to another
> >> +file.
> > The option requires an argument, so the argument should be mentioned
> > with the option and referenced in the text that describes it.
> 
> Sure, I also feel an example could help. How do you feel about this:
> 
> @cindex @option{--server-output}, @code{gdbserver} option
> The @option{--server-output=path} option tells @code{gdbserver} to send

@option{--server-output=@var{path}} (and once again, please use
"file" or "filename", not "path").

Also, what happened to the @item?

> all its output to a file given by @var{path}. This can be useful, for 
                                              ^^
Two spaces between sentences.

> @smallexample
> $ gdbserver --server-output=server.log :2222 testprog >test.out 2>test.err
> @end smallexample

This line is too long; either try to make it shorter, e.g., by using
shorter file/program names, or break it into 2 lines.

Otherwise, this is fine, thanks.
> > AFAIK, GNU Coding Standards frown on using "path" for anything that is
> > not PATH-style list of directories.  So please use "file" or "file
> > name" here.
> 
> I could not find a mention on the GNU Coding Standards manual itself, 

It's in the node "GNU Manuals":

     Please do not use the term "pathname" that is used in Unix
  documentation; use "file name" (two words) instead.  We use the term
  "path" only for search paths, which are lists of directory names.


  reply	other threads:[~2015-03-23 19:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  2:35 [PATCH 0/4] GDBServer: introduce a dedicated stderr stream Cleber Rosa
2015-03-21  2:35 ` [PATCH 3/4] GDBServer: introduce --server-stderr command line option Cleber Rosa
2015-03-21  8:26   ` Eli Zaretskii
2015-03-23 18:51     ` Cleber Rosa
2015-03-23 19:12       ` Eli Zaretskii [this message]
2015-03-23 20:35         ` Cleber Rosa
2015-03-23 20:43           ` Eli Zaretskii
2015-03-21  2:35 ` [PATCH 2/4] GDBServer: give more complete usage information Cleber Rosa
2015-03-21 17:05   ` Pedro Alves
2015-03-24 14:15     ` Cleber Rosa
2015-03-31 14:44       ` Cleber Rosa
2015-04-01 10:10       ` Pedro Alves
2015-03-21  2:35 ` [PATCH 1/4] GDBServer: introduce a stderr stream dedicated to the server Cleber Rosa
2015-03-21  2:35 ` [PATCH 4/4] GDBServer: add 'monitor set server-stderr' command Cleber Rosa
2015-03-21  8:29   ` Eli Zaretskii
2015-03-23 20:09     ` Cleber Rosa
2015-03-21 15:05 ` [PATCH 0/4] GDBServer: introduce a dedicated stderr stream Pedro Alves
2015-03-24 17:07   ` Cleber Rosa
2015-04-01 11:17     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83iodrr0j6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=areis@redhat.com \
    --cc=crosa@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox