From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121172-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 114417 invoked by alias); 25 Mar 2015 20:55:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 114403 invoked by uid 89); 25 Mar 2015 20:55:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Mar 2015 20:55:23 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NLS00500BYQ6Q00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Wed, 25 Mar 2015 22:50:22 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLS00143CJYRB50@mtaout25.012.net.il>; Wed, 25 Mar 2015 22:50:22 +0200 (IST)
Date: Wed, 25 Mar 2015 20:55:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 2/3] GDBServer: introduce --server-output command line option
In-reply-to: <1427316472-20629-3-git-send-email-crosa@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: gdb-patches@sourceware.org, crosa@redhat.com, areis@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iodool02.fsf@gnu.org>
References: <1427316472-20629-1-git-send-email-crosa@redhat.com> <1427316472-20629-3-git-send-email-crosa@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00836.txt.bz2

> From: Cleber Rosa <crosa@redhat.com>
> Cc: crosa@redhat.com, areis@redhat.com
> Date: Wed, 25 Mar 2015 17:47:51 -0300
> 
> This command line option will redirect all of the gdbserver's own
> output (always sent to stderr) to a separate file.  This feature makes
> it possible to distinguish between the inferior process stderr and
> gdbserver's own stderr.  Example use case:
> 
>  $ gdbserver --server-output=log :2222 bin >bin.out 2>bin.err
> 
> Server output will be sent to file named "log", and the inferior
> output and error messages will be on files "bin.out" and "bin.err",
> respectively.
> 
> gdb/Changelog:
> 2015-03-25  Cleber Rosa  <crosa@redhat.com>
> 
> 	* NEWS: New feature in the GDBserver: --server-output.
> 
> gdb/doc/ChangeLog:
> 2015-03-25  Cleber Rosa  <crosa@redhat.com>
> 
> 	* gdb.texinfo (info): Added section on command line and monitor
> 	commands.
> 	(gdbserver man): Added section on new command line option.

OK for the documentation parts, with one comment:

> +Server output will be sent to file named @var{log}, and the inferior
> +output and error messages will be on files @var{bin.out} and
> +@var{bin.err}, respectively.

These all should be @file, not @var, since they are literal file
names.

Thanks.