Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory

Pedro Alves
2015-06-17T11:55:50Z

On 06/15/2015 08:28 PM, Simon Marchi wrote:

>>> -> $m1000,8#??
>>> <- aaaabbbbccccdddd
>>>
>>> -> $M1000,6:eeeeffffeeee#??
>>> <- OK
>>>
>>> -> $m1000,8#??
>>> <- eeeeffffeeeedddd
>>>
>
> Ok, I put the example in the comment of remote_write_bytes_aux and added
> a reference to it in remote_read_bytes_1. Do you have a more suitable place
> in mind where to put it?

Nope, that sounds good.

> Thanks for the review. Here's what's new:
>
> * needs_escaping: Added newline and comment.
> * remote_escape_output: Add missing space.
> * remote_write_bytes_aux: Send length in addressable units, update comment with example gdb/stub exchange.
> * remote_read_bytes_1: Same, and update function comment (add UNIT_SIZE).

Looks good to me.

Thanks,
Pedro Alves