From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123538-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 92586 invoked by alias); 13 Jun 2015 06:49:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 92572 invoked by uid 89); 13 Jun 2015 06:49:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout29.012.net.il
Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Jun 2015 06:49:54 +0000
Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NPV00O00EX52J00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Sat, 13 Jun 2015 09:49:18 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPV00LNHEY6L220@mtaout29.012.net.il>; Sat, 13 Jun 2015 09:49:18 +0300 (IDT)
Date: Sat, 13 Jun 2015 06:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 3/7] Clarify doc about memory read/write and non-8-bits addressable memory unit sizes
In-reply-to: <557B40D5.1050204@ericsson.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ioasqf03.fsf@gnu.org>
References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-4-git-send-email-simon.marchi@ericsson.com> <83a8y89lj1.fsf@gnu.org> <557B40D5.1050204@ericsson.com>
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00273.txt.bz2

> Date: Fri, 12 Jun 2015 16:28:05 -0400
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: <gdb-patches@sourceware.org>
> 
> On 15-04-16 10:48 AM, Eli Zaretskii wrote:
> > This patch is fine with me, thanks.
> 
> Hi Eli,
> 
> I added some bits in the Remote Protocol section following the discussion
> with Pedro, could you review them?

Below.

> +@anchor{addressable memory unit}
> +@cindex addressable memory unit
> +Most targets have an addressable memory unit size of 8 bits.  This means
> +that to each memory address are associated 8 bits of data.  Some
> +targets, however, have other addressable memory unit sizes.
> +Within @value{GDBN} and this document, the term
> +@dfn{addressable memory unit} (or @dfn{memory unit} for short) is used
> +when explicitely referring to a chunk of data of that size.  The word
        ^^^^^^^^^^^
"explicitly"

> +Read @var{length} addressable memory units starting at address @var{addr}
> +(@pxref{addressable memory unit}). Note that @var{addr} may not be aligned to
> +any particular boundary.         ^^

Two spaces between sentences, please.

> +Write @var{length} addressable memory units starting at address @var{addr}
> +(@pxref{addressable memory unit}). The data is given by @var{XX@dots{}}; each
                                    ^^
Likewise.

Thanks.