From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111735 invoked by alias); 22 Aug 2015 07:23:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111724 invoked by uid 89); 22 Aug 2015 07:23:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Aug 2015 07:23:32 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NTH00B0035S5K00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 22 Aug 2015 10:23:09 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTH00B8V36K2H30@a-mtaout22.012.net.il>; Sat, 22 Aug 2015 10:23:09 +0300 (IDT) Date: Sat, 22 Aug 2015 07:23:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v12 06/32] Validate symbol file using build-id In-reply-to: <20150821212057.6673.70817.stgit@host1.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83io87iy79.fsf@gnu.org> References: <20150821212006.6673.35100.stgit@host1.jankratochvil.net> <20150821212057.6673.70817.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00633.txt.bz2 > From: Jan Kratochvil > Date: Fri, 21 Aug 2015 23:20:57 +0200 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -35,6 +35,20 @@ show debug bfd-cache > The "/m" option is now considered deprecated: its "source-centric" > output hasn't proved useful in practice. > > +* New options > + > +set validate-build-id (on|off) > +show validate-build-id > + Inferior shared library and symbol file may contain unique build-id. > + If both build-ids are present but they do not match then this setting > + enables (off) or disables (on) loading of such symbol file. > + > +* New features in the GDB remote stub, GDBserver > + > + ** library-list-svr4 contains also optional attribute 'build-id' for > + each library. GDB does not load library with build-id that > + does not match such attribute. > + > *** Changes in GDB 7.10 This is OK. > +static void > +show_validate_build_id (struct ui_file *file, int from_tty, > + struct cmd_list_element *c, const char *value) > +{ > + fprintf_filtered (file, _("Validation a build-id matches to load a shared " > + "library is %s.\n"), I think this message is not a valid English sentence. I suggest this instead: Validation of build-id match when loading a shared library is %s.\n > +void > +_initialize_build_id (void) > +{ > + add_setshow_boolean_cmd ("validate-build-id", class_support, > + &validate_build_id, _("\ > +Set validation a build-id matches to load a shared library."), _("\ Likewise here, I suggest this alternative: Set whether to validate build-id match when loading a shared library. > +SHow validation a build-id matches to load a shared library."), _("\ ^^ Capitalization. Also, if you accept my suggestion above, change this text accordingly. > +Inferior shared library and symbol file may contain unique build-id.\n\ > +If both build-ids are present but they do not match then this setting\n\ ^ ^ Commas missing where indicated. Thanks.