From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89028 invoked by alias); 20 Apr 2016 17:45:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88981 invoked by uid 89); 20 Apr 2016 17:45:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1638, caps, HX-Received-From:4830, HX-Received-From:134 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 20 Apr 2016 17:45:01 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aswBM-0005eM-J2 for gdb-patches@sourceware.org; Wed, 20 Apr 2016 13:44:59 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aswBM-0005eI-Fg; Wed, 20 Apr 2016 13:44:56 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3623 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aswBL-0006Fq-RV; Wed, 20 Apr 2016 13:44:56 -0400 Date: Wed, 20 Apr 2016 17:45:00 -0000 Message-Id: <83inzc6upa.fsf@gnu.org> From: Eli Zaretskii To: Doug Evans CC: gdb-patches@sourceware.org In-reply-to: (message from Doug Evans on Wed, 20 Apr 2016 10:30:13 -0700) Subject: Re: [PATCH] Improve maint print symbols,psymbols,msymbols Reply-to: Eli Zaretskii References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00485.txt.bz2 > From: Doug Evans > Date: Wed, 20 Apr 2016 10:30:13 -0700 > > 2016-04-20 Doug Evans > > * NEWS: Document new syntax for "mt print symbols", "mt print psymbols" > and "mt print msymbols" commands. > * psymtab.c (DEV_TTY): Delete. > (dump_psymtab_addrmap): Don't dump if psymtabs_addrmap is NULL. > (maintenance_print_psymbols): Rewrite for new syntax: > mt print psymbols [-objfile objfile] [-pc address] [outfile] > mt print psymbols [-objfile objfile] [-source source] [outfile] > (_initialize_psymtab): Update help text. > * symmisc.c (maintenance_print_symbols): Rewrite for new syntax: > mt print symbols [-pc address] [outfile] > mt print symbols [-objfile objfile] [-source source] [outfile] > (maintenance_print_msymbols): Rewrite for new syntax: > mt print msymbols [-objfile objfile] [outfile] > Only print symbols for the current progspace. > (_initialize_symmisc): Update help text. > > doc/ > * gdb.texinfo (Symbols): Update docs for symbol printing maintenance > commands. > > testsuite/ > * gdb.base/maint.exp: Update tests for maint print symbols, psymbols > and msymbols. OK for the documentation parts, except this nit: > +If @code{-objfile @var{OBJFILE}} is specified, only dump symbols for > +that objfile. > +If @code{-pc @var{address}} is specified, only dump symbols for the file > +with code at that address. Note that @var{address} may be a symbol like > +@code{main}. > +If @code{-source @var{SOURCE}} is specified, only dump symbols for that > +source file. The arguments of @var shouldn't be in CAPS. Thanks.