From: Eli Zaretskii <eliz@gnu.org>
To: Tim Wiederhake <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com,
markus.t.metzger@intel.com
Subject: Re: [PATCH v2 8/8] Add documentation for new instruction record Python bindings.
Date: Fri, 04 Nov 2016 08:16:00 -0000 [thread overview]
Message-ID: <83ins3lkxv.fsf@gnu.org> (raw)
In-Reply-To: <1478246074-14526-9-git-send-email-tim.wiederhake@intel.com> (message from Tim Wiederhake on Fri, 4 Nov 2016 08:54:34 +0100)
> From: Tim Wiederhake <tim.wiederhake@intel.com>
> Cc: palves@redhat.com, markus.t.metzger@intel.com
> Date: Fri, 4 Nov 2016 08:54:34 +0100
>
> gdb/doc/ChangeLog:
>
> * python.texi: Add record Python bindings entry.
This log entry should mention the node name.
> +@defvar Record.method
> +A string with the current recording method, e.g. @code{full} or
Please follow "e.g." either by a comma or by @:, so that it wouldn't
be taken as an end of the sentence.
Otherwise, the documentation part of this patch series is okay.
Thanks.
next prev parent reply other threads:[~2016-11-04 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 7:55 [PATCH v2 0/8] Python bindings for btrace recordings Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 8/8] Add documentation for new instruction record Python bindings Tim Wiederhake
2016-11-04 8:16 ` Eli Zaretskii [this message]
2016-11-04 7:55 ` [PATCH v2 5/8] python: Create Python bindings for record history Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 3/8] btrace: Use binary search to find instruction Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 4/8] Add record_start function Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 1/8] btrace: Count gaps as one instruction explicitly Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 7/8] python: Add tests for record Python bindings Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 2/8] btrace: Export btrace_decode_error function Tim Wiederhake
2016-11-04 7:55 ` [PATCH v2 6/8] python: Implement btrace Python bindings for record history Tim Wiederhake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ins3lkxv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox