From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118699 invoked by alias); 26 May 2017 12:57:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118571 invoked by uid 89); 26 May 2017 12:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=defect, mitigate X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 12:57:29 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEEo4-0007wM-73 for gdb-patches@sourceware.org; Fri, 26 May 2017 08:57:31 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEEo4-0007wI-47; Fri, 26 May 2017 08:57:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1074 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dEEo3-0006Bo-6G; Fri, 26 May 2017 08:57:27 -0400 Date: Fri, 26 May 2017 12:57:00 -0000 Message-Id: <83inknkc7f.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org In-reply-to: <1e36b12c-3cd5-8ea2-c9ba-f97fa8085c66@redhat.com> (message from Pedro Alves on Fri, 26 May 2017 12:52:27 +0100) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <20170504194442.63AAF60B72@joel.gnat.com> <83o9v3cs25.fsf@gnu.org> <91d9fc6cc7c07674a0b5cd02e7b1502b@polymtl.ca> <8360h38r1r.fsf@gnu.org> <20170517143136.mdnstf2u2jiydvnd@adacore.com> <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <83fufvm0ro.fsf@gnu.org> <436bb773-a9b2-6c32-2b9c-7d3a6297d634@redhat.com> <83shjsjbib.fsf@gnu.org> <1e36b12c-3cd5-8ea2-c9ba-f97fa8085c66@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00559.txt.bz2 > Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 26 May 2017 12:52:27 +0100 > > My understanding of the issue is that libstdc++ had a too-coarse way > to tell whether the runtime supports C99, and that ended up disabling > std::to_string because some unrelated (to std::to_string) bits of C99 > support are missing in mingw.org. That's another problem, but it doesn't matter in the case of MinGW, because the root cause was indeed affecting std::to_string, AFAIU. > I don't think the fix on the GCC side really requires a mingw runtime > update. I may well be wrong, of course. I think you are wrong. In the libstdc++ 5.3.0 distribution, the offending defines are in include/c++/mingw32/bits/c++config.h, which AFAIU is generated at libstdc++ build time. > I cloned the current mingw sources to see what's been done > over there, and here's what's there now (on the 5.0-active branch): You could have just downloaded the MinGW runtime from here: https://sourceforge.net/projects/mingw/files/MinGW/Base/mingwrt/mingwrt-5.0/libmingwex-5.0-mingw32-dev.tar.xz/download > #if _ISOC99_SOURCE && __cplusplus >= 201103L && __GNUC__ < 6 > /* Due to a configuration defect in GCC versions prior to GCC-6, when > * compiling C++11 code, the ISO-C99 functions may not be incorporated > * into the appropriate namespace(s); we may be able to mitigate this, > * by ensuring that these GCC configuration macros are defined. > */ > # define _GLIBCXX_USE_C99 1 > # define _GLIBCXX_HAVE_WCSTOF 1 > #endif > > I would have helped a lot if I had been shown this. Note the > "__GNUC__ < 6" check. Hey, that's unfair! You expect me to look at the MinGW64 headers and at related Bugzilla bugs, but you yourself cannot look in the MinGW headers? > If you're happy with the gdb fix in place now, I'm happy enough > with it too. I'm happy. Any problems with MinGW GCC 6.x don't matter as long as there's no such GCC version on the MinGW site.