From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26031 invoked by alias); 11 Jun 2018 15:25:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24876 invoked by uid 89); 11 Jun 2018 15:25:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=states X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jun 2018 15:25:04 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOgo-0004aR-8z for gdb-patches@sourceware.org; Mon, 11 Jun 2018 11:25:03 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOgg-0004SD-Pm; Mon, 11 Jun 2018 11:24:54 -0400 Received: from [176.228.60.248] (port=2072 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSOgg-0003ML-1q; Mon, 11 Jun 2018 11:24:54 -0400 Date: Mon, 11 Jun 2018 15:25:00 -0000 Message-Id: <83in6pqrap.fsf@gnu.org> From: Eli Zaretskii To: Petr Tesarik CC: gdb-patches@sourceware.org, jeffm@suse.com In-reply-to: <20180611120835.27343-3-ptesarik@suse.cz> (message from Petr Tesarik on Mon, 11 Jun 2018 14:08:33 +0200) Subject: Re: [PATCH v2 2/4] Make add-symbol-file's address argument optional Reply-to: Eli Zaretskii References: <20180611120835.27343-1-ptesarik@suse.cz> <20180611120835.27343-3-ptesarik@suse.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00282.txt.bz2 > From: Petr Tesarik > Cc: Petr Tesarik , Jeff Mahoney > Date: Mon, 11 Jun 2018 14:08:33 +0200 > > The (first) .text section must be always specified as the second > non-option argument. The documentation states that GDB cannot > figure out this address by itself. This is true if the object file > was indeed relocated, but it is also confusing, because all other > sections can be omitted and will use the address provided by BFD. > > gdb/ChangeLog: > 2018-06-11 Petr Tesarik > > * symfile.c (add_symbol_file_command, _initialize_symfile): Do not > require the second argument. If omitted, load sections at the > addresses specified in the file. > > gdb/doc/ChangeLog: > 2018-06-11 Petr Tesarik > > * gdb.texinfo (Files): The address argument for "add-symbol-file" > is no longer mandatory. > > gdb/testsuite/ChangeLog: > 2018-06-11 Petr Tesarik > > * gdb.base/relocate.exp: Test add-symbol-file behavior when the > address argument is omitted. I have a feeling I already reviewed and approved this, but in case I didn't, I approve it now. Thanks.