From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95155 invoked by alias); 11 Aug 2018 07:22:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95145 invoked by uid 89); 11 Aug 2018 07:22:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.2 spammy=excited, injection, encourage, Turns X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Aug 2018 07:22:09 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foODs-0002gV-JD for gdb-patches@sourceware.org; Sat, 11 Aug 2018 03:22:07 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foODs-0002gN-F0; Sat, 11 Aug 2018 03:22:04 -0400 Received: from [176.228.60.248] (port=3065 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1foODr-00055S-SC; Sat, 11 Aug 2018 03:22:04 -0400 Date: Sat, 11 Aug 2018 07:22:00 -0000 Message-Id: <83in4hmkpt.fsf@gnu.org> From: Eli Zaretskii To: Keith Seitz CC: gdb-patches@sourceware.org In-reply-to: <20180810232534.481-10-keiths@redhat.com> (message from Keith Seitz on Fri, 10 Aug 2018 16:25:34 -0700) Subject: Re: [PATCH 9/9] C++ compile support References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00315.txt.bz2 > From: Keith Seitz > Date: Fri, 10 Aug 2018 16:25:34 -0700 > > This initial support has several glaring omissions: > - No template support at all > I have follow-on patches for this, but they add much complexity > to this "basic" support. Consequently, they will be submitted separately. > - Cannot print functions > The code template needs tweaking, and I simply haven't gotten to it yet. > - So-called "special function" support is not included > Using constructors, destructors, operators, etc will not work. I have > follow-on patches for that, but they require some work because of the > recent churn in symbol searching. > - There are several test suite references to "compile/1234" bugs. > I will file bugs and update the test suite's bug references before pushing > these patches. Shouldn't these omissions be mentioned somewhere? Like in NEWS? > +* GDB now has experimental support for the compilation and injection of > + C++ source code into the inferior. This feature requires the GCC C++ > + plug-in available since GCC 7.1. The last sentence basically means "only on ELF platforms", right? So IMO this limitation should be stated explicitly, lest people get excited, and then get disappointed. > +set debug compile-oracle > +show debug compile-oracle > + Control the display of debug output about symbol requests from > + the compiler plug-in. > + > +set debug compile-cplus-types > +show debug compile-cplus-types > + Control the display of debug output about C++ type conversion > + in the compile feature. I suggest to mention that these commands are only available/have effect if the C++ compilation is supported. > +@anchor{set debug compile-oracle} > +@item set debug compile-oracle > +@cindex compile oracle debugging info > +Turns on or off display of symbol requests from the compiler plug-in > +(the ``oracle''). The default is off. @dfn{oracle} should render better. In any case, why do we call this "the oracle"? In the computing context, "oracle" has connotations that we don't necessarily want to encourage, I think. Why not something like "set debug symbol-requests"? > +Turns on or off the display of C++ type conversion debugging information. Please use C@t{++} for C++ in the text, it renders better in the printed manual. OK for the documentation parts, with those nits fixed. Thanks.