From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96728 invoked by alias); 19 Mar 2019 06:09:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96716 invoked by uid 89); 19 Mar 2019 06:09:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1040, explain X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 06:09:05 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h67vr-0004Jc-E9; Tue, 19 Mar 2019 02:09:03 -0400 Received: from [176.228.60.248] (port=1217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h67vq-0004N6-Ls; Tue, 19 Mar 2019 02:09:03 -0400 Date: Tue, 19 Mar 2019 06:09:00 -0000 Message-Id: <83imwfv1jd.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: tromey@adacore.com, gdb-patches@sourceware.org In-reply-to: <04e92055-4b62-5691-0425-d3110a862b31@redhat.com> (message from Pedro Alves on Mon, 18 Mar 2019 20:24:28 +0000) Subject: Re: [PATCH v2] Fix first time you type UP or DOWN in TUI's command window (Re: [RFC 8.3 0/3] Some style fixes) References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <83tvg4ywq2.fsf@gnu.org> <04e92055-4b62-5691-0425-d3110a862b31@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00402.txt.bz2 > Cc: tromey@adacore.com, gdb-patches@sourceware.org > From: Pedro Alves > Date: Mon, 18 Mar 2019 20:24:28 +0000 > > > Still, I'd welcome some comments in > > the header which explain the semantics of non-positive values of these > > members, and for m_start_of_line, also its role in general. Fixing > > this bug could have been much easier if that information was > > available to begin with. > For sure. This code predates me by a long shot. I wouldn't be > surprised if it was already in the original TUI dump from HP. > > Anyway, I've stared at this for a while, and I _think_ this captures > the idea. WDYT? Thanks, LGTM. It certainly explains the values of these two members and how they are used. > + { > + /* If we've reached the end of the line, so go back to > + letting text output go to the console. */ A minor typo: "If ..., so ..." sounds weird. I think you wanted to get rid of that "If".