From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114426 invoked by alias); 18 Apr 2019 12:52:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114410 invoked by uid 89); 18 Apr 2019 12:52:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=solicit, HX-Languages-Length:1811, invest X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 12:52:40 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hH6Wr-0003nK-DQ; Thu, 18 Apr 2019 08:52:37 -0400 Received: from [176.228.60.248] (port=4583 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hH6Wq-0000N2-T7; Thu, 18 Apr 2019 08:52:37 -0400 Date: Thu, 18 Apr 2019 12:52:00 -0000 Message-Id: <83imvbearj.fsf@gnu.org> From: Eli Zaretskii To: Joel Brobecker CC: gdb-patches@sourceware.org In-reply-to: <20190417221729.GA5839@adacore.com> (message from Joel Brobecker on Wed, 17 Apr 2019 15:17:29 -0700) Subject: Re: [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> <1555453982-77808-3-git-send-email-brobecker@adacore.com> <83imvcg0ud.fsf@gnu.org> <20190417173842.GA14817@adacore.com> <83wojseb9c.fsf@gnu.org> <20190417221729.GA5839@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00316.txt.bz2 > Date: Wed, 17 Apr 2019 15:17:29 -0700 > From: Joel Brobecker > Cc: gdb-patches@sourceware.org > > Personally, I feel the other way, especially since we always get > all sorts of random temporary thread notifications polutting the > output, that I don't mind the extra notification. And that way, > I know when each thread is actually terminated, and with what > error code. > > But if you and others feel differently, I can switch my approach: > > - patch #1 (master+8.3): Just fix the crash, and nothing more. > > This means that, on 8.3, thread creation and exit notifications > can be slightly off; this is considered an acceptable known > problem, and is not a regression. > > This is actually what we've put in AdaCore's GDB as a first > step to see we had any issue after that, and we did not. > > - patch #2 (master only): Remove uses of the global > > But we keep the filtering of the "main" thread. We still > the known problem that the thread-exit notifications might > be silenced for the wrong thread. Not a regression. > > - patch #3 (master only): Tag the main thread, and silence > the thread-exit notification of the thread that got tagged. > Depending on the implementation, this patch would potentially > be acceptable for 8.3, but might need extra work to apply. > I think we've had enough problems with 8.3 as it is, I don't > want to add more things to do, so I vote OUT for 8.3. > > I don't think I have time for that before the weekend or next week, > though. Mine is just one opinion. I think we should solicit opinions from others before you invest all that effort. If I'm the only one who is bothered by your original proposal, I think you should go ahead and push it. Thanks.