From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63315 invoked by alias); 6 May 2019 15:33:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63307 invoked by uid 89); 6 May 2019 15:33:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=luck X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 15:33:57 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNfcp-0005Uh-16; Mon, 06 May 2019 11:33:55 -0400 Received: from [176.228.60.248] (port=2801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNfco-0004NT-7C; Mon, 06 May 2019 11:33:54 -0400 Date: Mon, 06 May 2019 15:33:00 -0000 Message-Id: <83imunk372.fsf@gnu.org> From: Eli Zaretskii To: Kevin Buettner CC: gdb-patches@sourceware.org, simark@simark.ca In-reply-to: <20190505130403.56de7f08@f29-4.lan> (message from Kevin Buettner on Sun, 5 May 2019 13:04:03 -0700) Subject: Re: The 'cold' function attribute and GDB References: <83wojaovbp.fsf@gnu.org> <077aee8c-7bef-bad6-a6a1-e69f116cc18b@simark.ca> <20190501195113.69aea752@f30-4.lan> <20190502003849.6759d177@f29-4.lan> <83muk4q3rr.fsf@gnu.org> <20190502112517.64b6fa20@f29-4.lan> <83zho4ofkh.fsf@gnu.org> <20190502121305.111b5fdc@f29-4.lan> <83y33oodv2.fsf@gnu.org> <20190502124509.0d2c546c@f29-4.lan> <83sgtwock8.fsf@gnu.org> <20190502163015.507e652b@f29-4.lan> <835zqqmxk9.fsf@gnu.org> <20190505130403.56de7f08@f29-4.lan> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00169.txt.bz2 > Date: Sun, 5 May 2019 13:04:03 -0700 > From: Kevin Buettner > Cc: Eli Zaretskii , simark@simark.ca > > My patch is below. If it works for you and the approach seems sound, > I'll work on a test case which doesn't depend on gcc placing the > .cold section after the entry pc. The patch fixes the backtrace, thanks. The output from "info line" still references the .cold symbol, though. I think this was not so on GNU/Linux? Is it also by sheer luck, because of the order of the 'cold' symbols in the executable?