Re: [PATCH v2 6/7] Let the user control the startup style

Tom Tromey
2020-07-05T18:50:25Z

>> +@item startup
>> +Control the styling of some text that is printed at startup. These
>> +are managed with the @code{set style startup} family of commands. By
>> +default, this style's foreground color is magenta and it has bold
>> +intensity. Changing these settings will cause them to automatically
>> +be saved in a special configuration file, which is read by
>> +@value{GDBN} early in its startup.
>> +
>> +The default value for this directory depends on the host platform. On
Eli> ^^^^^^^^^^^^^^
Eli> The word "directory" doesn't appear in the previous paragraph, so it
Eli> is unclear what "this directory" refers to.

>> +most systems, the index is cached in the @file{gdb} subdirectory of
Eli> ^^^^^^^^^^^^^^^^^^^
Eli> Likewise with "index".

Eli> The documentation parts are OK with those nits fixed. Thanks.

Thanks for the review. I copied some text from the index cache section,
but I didn't sufficiently edit it. This appeared in another patch in
this series as well.

In both spots now, I've changed this paragraph to read:

+The directory in which this file appears depends on the host platform.
+On most systems, the file is in the @file{gdb} subdirectory of the
+directory pointed to by the @env{XDG_CONFIG_HOME} environment
+variable, if it is defined, else in the @file{.config/gdb}
+subdirectory of your home directory. However, on some systems, the
+default may differ according to local convention.

Tom