Re: [PATCH v2 6/7] Let the user control the startup style

Eli Zaretskii
2020-06-23T14:42:16Z

> From: Tom Tromey <tom@tromey.com>
> Date: Tue, 23 Jun 2020 07:20:05 -0600
> Cc: Tom Tromey <tom@tromey.com>
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index e977630c445..8f474c51bf4 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -80,6 +80,13 @@ show exec-file-mismatch -- Show exec-file-mismatch handling (ask|warn|off).
> executable file; if 'warn', just display a warning; if 'off', don't
> attempt to detect a mismatch.
>
> +set style startup foreground COLOR
> +set style startup background COLOR
> +set style startup intensity VALUE
> + Control the styling of startup text. This saves the setting into
> + a special configuration file, so that it can be read during startup
> + and applied.
> +

This is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -25672,6 +25672,21 @@ Control the styling of addresses. These are managed with the
> @code{set style address} family of commands. By default, this style's
> foreground color is blue.
>
> +@item startup
> +Control the styling of some text that is printed at startup. These
> +are managed with the @code{set style startup} family of commands. By
> +default, this style's foreground color is magenta and it has bold
> +intensity. Changing these settings will cause them to automatically
> +be saved in a special configuration file, which is read by
> +@value{GDBN} early in its startup.
> +
> +The default value for this directory depends on the host platform. On
^^^^^^^^^^^^^^
The word "directory" doesn't appear in the previous paragraph, so it
is unclear what "this directory" refers to.

> +most systems, the index is cached in the @file{gdb} subdirectory of
^^^^^^^^^^^^^^^^^^^
Likewise with "index".

The documentation parts are OK with those nits fixed. Thanks.