Re: [PATCH v2 2/7] Add "help news"

Tom Tromey
2020-07-11T15:31:31Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> $ make install DESTDIR=/tmp/install
Simon> ...
Simon> make[4]: *** No rule to make target 'install-news', needed by 'install-only'. Stop.

Oops, that's a leftover from an earlier iteration.
I fixed this.

Simon> (4) I tried what I mentioned just above and I get some sanitizer error:

Simon> $ ./gdb -q -nx --data-directory=data-directory
Simon> (gdb) help news
Simon> /home/simark/src/binutils-gdb/gdb/cli/cli-decode.c:1214:60: runtime error: index 1024 out of bounds for type 'char [1024]'

Simon> Not sure if it's ASan or UBSan.

Probably fixed by using read_entire_file, but I'll check.

Tom