Re: [PATCH v5 05/25] GDBserver remote packet support for memory tagging

Luis Machado via Gdb-patches
2021-02-05T12:39:04Z

On 2/4/21 11:56 PM, Simon Marchi wrote:
>> diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc
>> index cfdf1c1883..4e76f08ac5 100644
>> --- a/gdbserver/remote-utils.cc
>> +++ b/gdbserver/remote-utils.cc
>> @@ -1304,10 +1304,14 @@ prepare_resume_reply (char *buf, ptid_t ptid,
>> }
>> }
>>
>> -void
>> -decode_m_packet (char *from, CORE_ADDR *mem_addr_ptr, unsigned int *len_ptr)
>> +/* Decode ADDR and LEN from a parameter of the form "addr,len<x>", with <x>
>> + being an end marker character. */
>> +
>> +const char *
>> +decode_m_packet_params (const char *from, CORE_ADDR *mem_addr_ptr,
>> + unsigned int *len_ptr, const char end_marker)
>
> For new code, IWBN to follow the convention of putting the doc in the
> header, and putting /* See remote-utils.h. */ here.
>
> Otherwise, LGTM.

Thanks. I noticed the documentation is off. I updated it and moved it to
the header file.