Re: [PATCH v5 13/25] Convert char array to std::string in linux_find_memory_regions_full

Simon Marchi via Gdb-patches
2021-02-05T03:32:56Z

> @@ -1296,10 +1294,12 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch,
>
> if (use_coredump_filter)
> {
> - xsnprintf (coredumpfilter_name, sizeof (coredumpfilter_name),
> - "/proc/%d/coredump_filter", pid);
> + std::string core_dump_filter_name
> + = string_printf ("/proc/%d/coredump_filter", pid);
> +
> gdb::unique_xmalloc_ptr<char> coredumpfilterdata
> - = target_fileio_read_stralloc (NULL, coredumpfilter_name);
> + = target_fileio_read_stralloc (NULL, core_dump_filter_name.c_str());

Space before parenthesis.

Otherwise, LGTM.

Simon