Re: [PATCH v5 11/25] AArch64: Add MTE ptrace requests

Simon Marchi via Gdb-patches
2021-02-05T03:13:28Z

On 2021-01-27 3:20 p.m., Luis Machado via Gdb-patches wrote:
> This patch adds the required ptrace request definitions into a new include
> file that will be used by the next patches.
>
> They are PTRACE_PEEKMTETAGS and PTRACE_POKEMTETAGS.
>
> gdb/ChangeLog:
>
> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>
> * Makefile.in (HFILES_NO_SRCDIR): Add nat/aarch64-mte-linux-ptrace.h.
> * nat/aarch64-mte-linux-ptrace.h: New file.
> ---
> gdb/Makefile.in | 1 +
> gdb/nat/aarch64-mte-linux-ptrace.h | 33 ++++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 gdb/nat/aarch64-mte-linux-ptrace.h
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 4e1e6da88d..b763351912 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1506,6 +1506,7 @@ HFILES_NO_SRCDIR = \
> nat/aarch64-linux.h \
> nat/aarch64-linux-hw-point.h \
> nat/aarch64-sve-linux-ptrace.h \
> + nat/aarch64-mte-linux-ptrace.h \

Let's keep this list in order :)

> nat/amd64-linux-siginfo.h \
> nat/gdb_ptrace.h \
> nat/gdb_thread_db.h \
> diff --git a/gdb/nat/aarch64-mte-linux-ptrace.h b/gdb/nat/aarch64-mte-linux-ptrace.h
> new file mode 100644
> index 0000000000..099b6440ca
> --- /dev/null
> +++ b/gdb/nat/aarch64-mte-linux-ptrace.h
> @@ -0,0 +1,33 @@
> +/* Common native Linux definitions for AArch64 MTE.
> +
> + Copyright (C) 2018-2020 Free Software Foundation, Inc.

2021

Otherwise, LGTM.

Simon