From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id D8NjAdz3FGL4RwAAWB0awg (envelope-from ) for ; Tue, 22 Feb 2022 09:49:00 -0500 Received: by simark.ca (Postfix, from userid 112) id EF2E31F3CB; Tue, 22 Feb 2022 09:48:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 875441F0E7 for ; Tue, 22 Feb 2022 09:48:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF68E3858032 for ; Tue, 22 Feb 2022 14:48:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF68E3858032 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1645541338; bh=jSRzCZbqJCIy0PM7ETzn+E2QWcIvutFgQ92Z59gzQwM=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Aj+W7Yqfim+b1K+MMcwjYwmSB6rPVa0dhNSWkyVB+ZHBDR4MbBg01I4/UjkESmi2Y bVGWovJENzjcFsXgVIRNUo7RCp3bX+Di87C+aamOvwZr7RZmu34ySOykZiHG0j62bw fPkmo/jiSrYZH39BLKOtOAuhlMmT2Baoiu08Edn0= Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id 091C93858032 for ; Tue, 22 Feb 2022 14:48:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 091C93858032 Received: from [2001:470:142:3::e] (port=50054 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMWT1-00070y-JH; Tue, 22 Feb 2022 09:48:39 -0500 Received: from [87.69.77.57] (port=1902 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMWT1-0006J6-29; Tue, 22 Feb 2022 09:48:39 -0500 Date: Tue, 22 Feb 2022 16:48:46 +0200 Message-Id: <83ilt7t0s1.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <87sfsbattq.fsf@redhat.com> (message from Andrew Burgess on Tue, 22 Feb 2022 13:56:17 +0000) Subject: Re: [PATCH] gdb/python: add gdb.Architecture.format_address References: <20220211161721.3252422-1-aburgess@redhat.com> <83leyhs07f.fsf@gnu.org> <878ru4cepy.fsf@redhat.com> <837d9oumhd.fsf@gnu.org> <87sfsbattq.fsf@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Cc: gdb-patches@sourceware.org > Date: Tue, 22 Feb 2022 13:56:17 +0000 > > So, appologies, but this is another complete rewrite of the docs. With > the exception of the name, for which I still have no better suggestions, > how's this? Let's see... > +@defun Architecture.format_address (@var{address}) > +Return a string in the format @samp{@var{addr} > +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address} > +formatted in hexadecimal, @var{symbol} is the closest earlier symbol > +to @var{address}, and @var{offset} is the offset from @var{symbol} to > +@var{address} in decimal. I think instead of "closest earlier" it would be best to say ... @var{symbol} is the symbol whose address is the nearest to @var{address} and below it in memory ... Other than that, SGTM, thanks.