From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rmtxED60T2LnDAAAWB0awg (envelope-from ) for ; Fri, 08 Apr 2022 00:04:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 330731F344; Fri, 8 Apr 2022 00:04:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B36F1EDF0 for ; Fri, 8 Apr 2022 00:04:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 368A53858009 for ; Fri, 8 Apr 2022 04:04:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 368A53858009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649390651; bh=EqqpgNkh9tDNSxNV8Wu6uZbTISuhgkcI2sHyaWmSWbs=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sOF6rwBqYtE8TtahLYoGXn2gzMuyQ+8vkQCRPYN0EYB+sgZzCrebCDdX7LZ2OTc++ CICyWRtfU3uUIC7b7KniXV8nNTNSAbzZPnGjsVMmqQdxuAt3m1gQugIe8gjsM6C+Gx Q2b3ix5iABI3uGPxYbCmudY21mQ1IpinAQGZP0yY= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F2B0B385840C for ; Fri, 8 Apr 2022 04:03:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2B0B385840C Received: from fencepost.gnu.org ([2001:470:142:3::e]:57772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncfqg-00024j-NU; Fri, 08 Apr 2022 00:03:50 -0400 Received: from [87.69.77.57] (port=3560 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncfqg-00042c-58; Fri, 08 Apr 2022 00:03:50 -0400 Date: Fri, 08 Apr 2022 07:04:00 +0300 Message-Id: <83ilrkb4r3.fsf@gnu.org> To: Pedro Alves In-Reply-To: <330c3629-46ec-7b5b-3892-26362f5ada5b@palves.net> (message from Pedro Alves on Thu, 7 Apr 2022 20:22:55 +0100) Subject: Re: GDB 12.0.90 available for testing References: <83ilrzap07.fsf@gnu.org> <83mth67i8m.fsf@gnu.org> <72ad3448-0ff0-f36c-d1f3-cc194c0503b8@palves.net> <83ee2i72vl.fsf@gnu.org> <87sfqx864d.fsf@redhat.com> <83fsmx59wi.fsf@gnu.org> <83ee2h59m2.fsf@gnu.org> <87pmm096dc.fsf@redhat.com> <83zgl44w1m.fsf@gnu.org> <1379565857.1750775.1648990951974@mail.yahoo.com> <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> <330c3629-46ec-7b5b-3892-26362f5ada5b@palves.net> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: brobecker@adacore.com, aburgess@redhat.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Thu, 7 Apr 2022 20:22:55 +0100 > Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org, brobecker@adacore.com > From: Pedro Alves > > On 2022-04-07 12:09, Eli Zaretskii wrote: > > --- gdb/event-top.c~0 2022-03-20 06:59:56.000000000 +0200 > > +++ gdb/event-top.c 2022-04-01 14:06:22.164500000 +0300 > > @@ -821,19 +821,6 @@ gdb_readline_no_editing_callback (gdb_cl > > FILE *stream = ui->instream != nullptr ? ui->instream : ui->stdin_stream; > > gdb_assert (stream != nullptr); > > > > - /* Unbuffer the input stream, so that, later on, the calls to fgetc > > - fetch only one char at the time from the stream. The fgetc's will > > - get up to the first newline, but there may be more chars in the > > - stream after '\n'. If we buffer the input and fgetc drains the > > - stream, getting stuff beyond the newline as well, a select, done > > - afterwards will not trigger. > > - > > - This unbuffering was, at one point, not applied if the input stream > > - was a tty, however, the buffering can cause problems, even for a tty, > > - in some cases. Please ensure that any changes in this area run the MI > > - tests with the FORCE_SEPARATE_MI_TTY=1 flag being passed. */ > > Don't we want to preserve this comment? > > > - setbuf (stream, NULL); > > - This part of the patch is from Andrew, so I have no opinion about that. If we want to preserver it, I guess it should be moved to one of the places where we call setbuf instead of this single place?