From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6SHhLcRGLWT3wyMAWB0awg (envelope-from ) for ; Wed, 05 Apr 2023 06:00:36 -0400 Received: by simark.ca (Postfix, from userid 112) id B08B31E15D; Wed, 5 Apr 2023 06:00:36 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=jkpiqL9L; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C8041E0D2 for ; Wed, 5 Apr 2023 06:00:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2C723858C2B for ; Wed, 5 Apr 2023 10:00:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2C723858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680688836; bh=fKnFqrolIuX3J4bBDdZFSmkh4X6SxdY5Ub80/KGes+E=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jkpiqL9LH1T/3x2uvVbBOxrrKlGj9Odt9OQS7kSJg23dz2ICC5o0fdo1n05mR7eiO YVxicQToJSTIOZxgm0NxbQI+zQouzjf0CxTehQUB2JvKZ0YPCTKO/3+HsXU36EMYM2 KrBkqa2craP0jsmFtEogOKHn1Kwqo3QDmkK3JokE= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A69153858D20 for ; Wed, 5 Apr 2023 10:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A69153858D20 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzw3-0000wp-HP; Wed, 05 Apr 2023 06:00:16 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzw2-00081N-Ri; Wed, 05 Apr 2023 06:00:11 -0400 Date: Wed, 05 Apr 2023 13:00:38 +0300 Message-Id: <83ileasl6h.fsf@gnu.org> To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org In-Reply-To: (message from Tankut Baris Aktemur via Gdb-patches on Wed, 5 Apr 2023 11:20:02 +0200) Subject: Re: [PATCH 3/3] gdb: add a '-stopped' option to "info threads" References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Wed, 5 Apr 2023 11:20:02 +0200 > From: Tankut Baris Aktemur via Gdb-patches > > gdb/NEWS | 7 ++ > gdb/doc/gdb.texinfo | 6 +- > gdb/testsuite/gdb.base/options.exp | 11 ++- > .../gdb.threads/info-threads-stopped.c | 78 +++++++++++++++++++ > .../gdb.threads/info-threads-stopped.exp | 75 ++++++++++++++++++ > gdb/thread.c | 17 +++- > 6 files changed, 190 insertions(+), 4 deletions(-) > create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.c > create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.exp Thanks, the documentation parts are OK. But I have a question about the new behavior: > (gdb) info threads -stopped 3 > No stopped threads match '3'. Is it really useful to show nothing and emit an error message if explicit thread IDs were specified by the user? Wouldn't it be better to ignore the -stopped switch in that case? Reviewed-By: Eli Zaretskii