From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HgecOCTXv2S3ny4AWB0awg (envelope-from ) for ; Tue, 25 Jul 2023 10:07:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=m7gLF/xe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D940E1E0C0; Tue, 25 Jul 2023 10:07:32 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B34731E00F for ; Tue, 25 Jul 2023 10:07:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37F273858D3C for ; Tue, 25 Jul 2023 14:07:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37F273858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690294049; bh=w4yekgWpgJlVw4I5bJ9j2cHnpqLAdI2aIXvHtupsT6k=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=m7gLF/xePp8l4eCRvk8dlh9I/ca+XmimZLXBHJtI+Jh8w2dVXGXXlont5QD3YO3v1 nA1RuArHL2sAqnXIsxxwAV/kih1svztRe9dlU3ndUj/EkfOMjZMEaZSAmAKDOt02bJ kbxdUkj7I3QRsTQ/B3OsXyvOGE3NEutWstOBsy/s= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C841C3858D3C for ; Tue, 25 Jul 2023 14:07:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C841C3858D3C Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOIgp-0006kD-M8; Tue, 25 Jul 2023 10:07:05 -0400 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOIgo-0002Mg-9l; Tue, 25 Jul 2023 10:07:03 -0400 Date: Tue, 25 Jul 2023 17:07:48 +0300 Message-Id: <83ila8ozij.fsf@gnu.org> To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230725-dap-bt-path-v1-3-bb015b0d8e54@adacore.com> (message from Tom Tromey via Gdb-patches on Tue, 25 Jul 2023 07:49:40 -0600) Subject: Re: [PATCH 3/6] Add "cwd" parameter to DAP launch request References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> <20230725-dap-bt-path-v1-3-bb015b0d8e54@adacore.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Tue, 25 Jul 2023 07:49:40 -0600 > From: Tom Tromey via Gdb-patches > > This adds the "cwd" parameter to the DAP launch request. > > This came up here: > https://github.com/eclipse-cdt-cloud/cdt-gdb-adapter/issues/90 > ... and seemed like a good idea. > --- > gdb/doc/gdb.texinfo | 8 ++++++++ > gdb/python/lib/gdb/dap/launch.py | 34 ++++++++++++++++----------------- > gdb/testsuite/gdb.dap/cwd.exp | 40 +++++++++++++++++++++++++++++++++++++++ > gdb/testsuite/lib/dap-support.exp | 5 +++++ > 4 files changed, 70 insertions(+), 17 deletions(-) OK for the documentation part, thanks. Reviewed-By: Eli Zaretskii