From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ESExC3k3A2WpFBYAWB0awg (envelope-from ) for ; Thu, 14 Sep 2023 12:40:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=c80JHsz+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 231A11E0C3; Thu, 14 Sep 2023 12:40:25 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 105381E092 for ; Thu, 14 Sep 2023 12:40:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84F233857B9B for ; Thu, 14 Sep 2023 16:40:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84F233857B9B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694709622; bh=6Bp6keyPEe8uL8zon9n3lBiFlx/0rlGcTyahXCQGKqA=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=c80JHsz+xG5lFB8G+RZPqNwoIWwKypj9Vb2KZF9aaQjnNHgJwoHzdKsmw3T8/9SI1 vOs93VnX2nIcrJuuZgQV0pX325+yY6tIDyv5toCqq9ynj4qa8SH+8FmElvkw6+PXcl 2BWO3/nNBEYPuFbjjItZAmNCAqrmHINVjcDii9qU= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 492053858C52 for ; Thu, 14 Sep 2023 16:40:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 492053858C52 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgpNo-0001CY-FE; Thu, 14 Sep 2023 12:40:00 -0400 Date: Thu, 14 Sep 2023 19:39:51 +0300 Message-Id: <83il8clne0.fsf@gnu.org> To: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20230914161433.432600-3-simon.marchi@efficios.com> (message from Simon Marchi via Gdb-patches on Thu, 14 Sep 2023 12:14:19 -0400) Subject: Re: [PATCH v2 3/3] gdb/amdgpu: add precise-memory support References: <20230914161433.432600-1-simon.marchi@efficios.com> <20230914161433.432600-3-simon.marchi@efficios.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Cc: Simon Marchi > Date: Thu, 14 Sep 2023 12:14:19 -0400 > From: Simon Marchi via Gdb-patches > > gdb/amd-dbgapi-target.c | 173 +++++++++++++++++- > gdb/doc/gdb.texinfo | 43 +++++ > gdb/testsuite/gdb.rocm/precise-memory-exec.c | 44 +++++ > .../gdb.rocm/precise-memory-exec.exp | 58 ++++++ > gdb/testsuite/gdb.rocm/precise-memory-fork.c | 41 +++++ > .../gdb.rocm/precise-memory-fork.exp | 50 +++++ > .../precise-memory-multi-inferiors.exp | 87 +++++++++ > .../precise-memory-warning-sigsegv.cpp | 33 ++++ > .../precise-memory-warning-sigsegv.exp | 45 +++++ > gdb/testsuite/gdb.rocm/precise-memory.cpp | 32 ++++ > gdb/testsuite/gdb.rocm/precise-memory.exp | 57 ++++++ > gdb/testsuite/lib/rocm.exp | 19 ++ > 12 files changed, 677 insertions(+), 5 deletions(-) > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.c > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.c > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.cpp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.exp Thanks. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 9b7e06f31566..aa3c67788871 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo This part is OK. Reviewed-By: Eli Zaretskii