From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7793 invoked by alias); 17 Apr 2009 15:26:16 -0000 Received: (qmail 7780 invoked by uid 22791); 17 Apr 2009 15:26:15 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Apr 2009 15:26:09 +0000 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KI9007003P7YB00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Fri, 17 Apr 2009 18:25:32 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.183.184]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KI900DGF46KIA50@i-mtaout7.012.net.il>; Fri, 17 Apr 2009 18:25:32 +0300 (IDT) Date: Fri, 17 Apr 2009 15:26:00 -0000 From: Eli Zaretskii Subject: Re: install-html and install-pdf improvements In-reply-to: To: "Joseph S. Myers" Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hc0njo9e.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00435.txt.bz2 > Date: Fri, 17 Apr 2009 11:47:39 +0000 (UTC) > From: "Joseph S. Myers" > > This patch improves "make install-html" and "make install-pdf" support > for GDB: > > * There are toplevel configure options --with-htmldir and > --with-pdfdir to control where HTML and PDF manuals are installed. > This patch makes the gdb/ directory follow these rather than > hardcoding its own directory settings. Thanks. > * The readline and sim directories need some dummy rules so that these > targets work at toplevel. I believe patches to readline need to be sent elsewhere. We just import their stuff. Maybe sim as well. > OK to commit? Yes, but I don't understand why did you need to define docdir in addition to pdfdir and htmldir. Unlike the other two, docdir is not used anywhere, so why define it? Other than that, the patches to files in gdb/doc/ are approved. The patches to gdb/ directory are fine with me, but I'd like others to comment on them as well.