From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21639 invoked by alias); 18 Apr 2009 17:01:16 -0000 Received: (qmail 21137 invoked by uid 22791); 18 Apr 2009 17:01:13 -0000 X-SWARE-Spam-Status: No, hits=3.5 required=5.0 tests=AWL,BAYES_00,BOTNET,J_CHICKENPOX_37,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Apr 2009 17:01:07 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KIB0070035S6N00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Sat, 18 Apr 2009 20:00:01 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.144.191]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIB00JS037ZA760@i-mtaout1.012.net.il>; Sat, 18 Apr 2009 20:00:00 +0300 (IDT) Date: Sat, 18 Apr 2009 17:01:00 -0000 From: Eli Zaretskii Subject: Re: [patch][rfc] Allow GDB to search for the right libthread_db.so.1 In-reply-to: <8ac60eac0904171213p4c075224x5f5c3661d240f383@mail.gmail.com> To: Paul Pluzhnikov Cc: tromey@redhat.com, bauerman@br.ibm.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hc0lj3sd.fsf@gnu.org> References: <20090406203920.CCD6F19C4EC@localhost> <1239225742.8871.145.camel@localhost.localdomain> <8ac60eac0904101205h76d8377cv843db8177e74f8af@mail.gmail.com> <8ac60eac0904171213p4c075224x5f5c3661d240f383@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00486.txt.bz2 > Date: Fri, 17 Apr 2009 12:13:08 -0700 > From: Paul Pluzhnikov > Cc: Thiago Jung Bauermann , gdb-patches ml > > Attached is a revised patch, with updated ChangeLog and documentation > changes. Thanks. Please also add a new entry to NEWS, in the "New options" section. We have just decided to have all the new options mentioned there. > doc/ChangeLog > > 2009-04-17 Paul Pluzhnikov > > * gdb.texinfo (Threads): Document libthread-db-search-path. This part is approved, with a few comments: > +@table @code > +@kindex set libthread-db-search-path > +@item set libthread-db-search-path @r{[}@var{path}@r{]} > +If this variable is set, @var{path} is a colon-separated list of > +directories @value{GDBN} will use to search for @code{libthread_db}. I would add here some suitable @cindex entry, for those who don't know or don't remember the name of the variable. Something like @cindex search path for @code{libthread_db} > +If you omit @var{path}, @samp{libthread-db-search-path} will be reset to > +empty list. "will be reset to an empty list", with the article. > +inferior process. @value{GDBN} first attempts to use > +@code{libthread_db} located in the same directory, from which ^ In English, there's no need for a comma here. Actually, it would sound a bit better if you remove the word "same" from this sentence. > +If none of @code{libthread_db} libraries initialize successfully, > +thread debugging will be disabled. I think we should mention here that GDB displays a warning in this case. > +Setting @code{libthread-db-search-path} is currently implemented > +only for @sc{gnu}/Linux targets. In general, mentioning specific platforms in the manual is a maintenance nightmare, because we must remember to make changes in the manual to track the support of the feature on other platforms. It is much better to say that this feature is available "only on some platforms." That's assuming that on other platforms, using the command will cause a suitable error message; does it? Btw, what are the Linux-specific aspects that this feature depends on? Why can't we implement it on Solaris as well?