From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31112 invoked by alias); 16 Jan 2010 08:03:20 -0000 Received: (qmail 30754 invoked by uid 22791); 16 Jan 2010 08:03:19 -0000 X-SWARE-Spam-Status: No, hits=0.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Jan 2010 08:03:14 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KWB00M00Y65I700@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 16 Jan 2010 10:03:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.60.183]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KWB00LSOYD5P530@a-mtaout20.012.net.il>; Sat, 16 Jan 2010 10:03:06 +0200 (IST) Date: Sat, 16 Jan 2010 08:03:00 -0000 From: Eli Zaretskii Subject: Re: [1/4] RFC: refactor partial symbol tables In-reply-to: To: tromey@redhat.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hbqmcw7u.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00429.txt.bz2 > From: Tom Tromey > Date: Fri, 15 Jan 2010 17:25:18 -0700 > > This patch does the bulk of the work. > > I went through gdb and looked at all uses of partial symbol tables. I > moved all the psymtab code into a new file, and changed all the code in > gdb to call via a new struct of function pointers. > > Mostly this was straightforward. The only surprise that I can remember > was that Ada walks the psymtabs directly. > > Now, symbol readers are allowed to include psympriv.h and access partial > symbol tables. However, generic code should not do this. This ensures > that partial symbol tables don't leak out into the main part of gdb. > > The new "quick" function API is entirely ad hoc, based on existing gdb > code. I consolidated functions in a few places, but perhaps more could > be done here. Thanks. Please look at the relevant sections of gdbint.texinfo and see if something needs an update there, due to these changes.