From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17347 invoked by alias); 24 Apr 2010 11:40:47 -0000 Received: (qmail 17315 invoked by uid 22791); 24 Apr 2010 11:40:45 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Apr 2010 11:40:38 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L1D00700PQPG800@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 24 Apr 2010 14:40:36 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.71.78]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L1D007DAPRMF000@a-mtaout21.012.net.il>; Sat, 24 Apr 2010 14:40:36 +0300 (IDT) Date: Sat, 24 Apr 2010 11:40:00 -0000 From: Eli Zaretskii Subject: Re: [gdb/libiberty] Improve support for cross debugging shared libraries with DOS style pathnames (from Unix hosts) In-reply-to: <201004241217.46557.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org Reply-to: Eli Zaretskii Message-id: <83hbn113k9.fsf@gnu.org> References: <201004221824.27019.pedro@codesourcery.com> <201004231146.22671.pedro@codesourcery.com> <83ljce2q5c.fsf@gnu.org> <201004241217.46557.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00832.txt.bz2 > From: Pedro Alves > Date: Sat, 24 Apr 2010 12:17:46 +0100 > Cc: gcc-patches@gcc.gnu.org > > On Friday 23 April 2010 15:35:11, Eli Zaretskii wrote: > > Not only is it clearer, it's in GNU coding standards, see my other > > mail. > > Okay, I changed all user visible strings, I think. Thanks. > > No, it's clear enough. I just wondered why you didn't remove the > > drive letter right away. I guess that's common practice in some > > quarters to mount DOS-ish filesystems that way. I don't really mind > > to support that if people are using it. > > Hope you don't mind, I ended up extending the docs here to > explicitly explain why the lookup algorith is the way it is, > so that users don't wonder the same you did. I don't mind, of course. Thanks for the extra effort. > I've moved that new target filesystem handling code to a > new file, and, handled DJGPP's gdbarch. Again, thanks. > I think this updated patch addresses all your comments. Could > you please take a new quick look at this? It's fine, I have only 2 minor nits to report: > +Then, @value{GDBN} attempts prefixing the target file name with > +@var{path}, and look for the resulting file name in the host file > +system: ^^^^ "looks" > +@smallexample > + @file{/path/to/sysroot/c/sys/bin/foo.dll} > + @file{/path/to/sysroot/c/sys/bin/bar.dll} > + @file{/path/to/sysroot/z/sys/bin/bar.dll} > +@end smallexample > + > +and point the system root at @file{/path/to/sysroot}, so that We need @noindent before the last line.