Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFA/commit/Windows] run program with space in path to exe.
Date: Sat, 20 Oct 2012 08:03:00 -0000	[thread overview]
Message-ID: <83happzi44.fsf@gnu.org> (raw)
In-Reply-To: <1350692925-14181-1-git-send-email-brobecker@adacore.com>

> From: Joel Brobecker <brobecker@adacore.com>
> Cc: Joel Brobecker <brobecker@adacore.com>
> Date: Fri, 19 Oct 2012 17:28:45 -0700
> 
> The following works...
> 
>     % gdb c:\path to exe\foo.exe
>     (gdb) start
> 
> ... unless a file or directory called "c:\path" or "c:\path to" exists.
> This is what happens in the latter case:
> 
>     (gdb) start
>     [...]
>     Error creating process C:\path to exe\foo.exe (error 193).
> 
> This is because we are calling CreateProcess (et al) without specifying
> the lpApplicationName, so Windows determines the name of the executable
> using the second argument, which is the entire command line.  This
> command line is a space-separated list of tokens, so the space in
> the path to the executable which potentially creates an ambiguity.
> The ambiguity is automatically resolved unless we're in the situation
> above.

Does it work if you say

  % gdb "\"c:\path to exe\foo.exe\""

instead?

>   3. Theoretically, I have a feeling that we're breaking the case
>      where the executable name contains a double quote in it.

This is impossible, at least in the MinGW case: Windows file names
cannot include the quote character.  See

  http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx

But what happens if the program name is already quoted?  A user can do
that if she realizes the problem in advance, certainly if the program
name is specified at the GDB prompt, as in 'file "c:\foo bar\my.exe"'.
I think we should detect this case and not quote it again.

Also, what about the arguments to the program?  Don't they have the
same issue when you use --args on the GDB command line?


  reply	other threads:[~2012-10-20  8:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-20  0:29 Joel Brobecker
2012-10-20  8:03 ` Eli Zaretskii [this message]
2012-10-20 16:30   ` Joel Brobecker
2012-10-20 17:20     ` Eli Zaretskii
2012-10-24 13:42       ` Checked in: " Joel Brobecker
2012-10-24 14:34         ` Pedro Alves
2012-10-24 14:47           ` Joel Brobecker
2012-10-24 14:57             ` Pedro Alves
2012-10-24 15:01               ` Joel Brobecker
2012-10-24 15:08                 ` Pedro Alves
2012-10-25  2:48                 ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83happzi44.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox