From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28705 invoked by alias); 7 Dec 2012 09:30:16 -0000 Received: (qmail 28695 invoked by uid 22791); 7 Dec 2012 09:30:15 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 09:30:08 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MEN00100MCUCU00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Dec 2012 11:29:38 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEN001L3MDDCR00@a-mtaout21.012.net.il>; Fri, 07 Dec 2012 11:29:38 +0200 (IST) Date: Fri, 07 Dec 2012 09:30:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/mingw32] environment variables are case-insensitive on win32 In-reply-to: <20121207092202.GJ7555@adacore.com> To: Jerome Guitton Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hanynrbk.fsf@gnu.org> References: <1354282597-22691-1-git-send-email-guitton@adacore.com> <834nk7urs0.fsf@gnu.org> <20121130140844.GF2768@adacore.com> <83y5hjt8ll.fsf@gnu.org> <20121130153401.GH2768@adacore.com> <83wqx3t6r9.fsf@gnu.org> <20121130162852.GD32262@adacore.com> <83pq2uudjj.fsf@gnu.org> <20121207092202.GJ7555@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00135.txt.bz2 > Date: Fri, 7 Dec 2012 10:22:02 +0100 > From: Jerome Guitton > Cc: gdb-patches@sourceware.org > > Eli Zaretskii (eliz@gnu.org): > > > Configure-time test is not good enough, as the binary could then be > > run in a different environment. > > > > How about making it case-insensitive for Cygwin as well? > > I ended up implementing Pedro's suggestion (a run-time test) but it > does not work in the case of Cygwin; getenv/setenv acts as if we add a > case-sensitive environment, but we use CreateProcess to create the > inferior, so we end up with a case-insensitive environment for the > inferior. So making it case-insensitive is indeed what makes sense. > > Last versions of the patch in attachment, along with the testcase. > Fully tested on x86_64-linux; partially tested on Cygwin (e.g. without > gdb.threads) amd mingw32 (testenv.exp only). > > Any comments? The attached patch still uses a run-time test. Did you attach a wrong patch?