From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2218 invoked by alias); 18 Dec 2012 19:16:25 -0000 Received: (qmail 2210 invoked by uid 22791); 18 Dec 2012 19:16:24 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 19:16:06 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MF800H00QQ1YH00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Dec 2012 21:16:04 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MF800HIYQUSYA10@a-mtaout21.012.net.il>; Tue, 18 Dec 2012 21:16:04 +0200 (IST) Date: Tue, 18 Dec 2012 19:16:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/commit 2/2] Import gnulib's errno module. In-reply-to: <87r4mnqk90.fsf@fleche.redhat.com> To: Tom Tromey Cc: brobecker@adacore.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hanjp3we.fsf@gnu.org> References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> <87r4mns49t.fsf@fleche.redhat.com> <20121218165035.GI3273@adacore.com> <87ehins375.fsf@fleche.redhat.com> <20121218181104.GM3273@adacore.com> <87r4mnqk90.fsf@fleche.redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00658.txt.bz2 > From: Tom Tromey > Cc: gdb-patches@sourceware.org > Date: Tue, 18 Dec 2012 11:37:47 -0700 > > A couple choices -- > > 1. Ensure that charset.c includes the files in the correct order. > > 2. Back out your change and promote the EILSEQ define out of charset.c > to somewhere more global in gdb. How about 3. Test for either ENOENT or EILSEQ where we now test for EILSEQ. ? We could also test whether GNULIB_defined_EILSEQ is defined, if worse comes to worst.