From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117326-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20768 invoked by alias); 6 Nov 2014 16:28:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20748 invoked by uid 89); 6 Nov 2014 16:28:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout28.012.net.il
Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Nov 2014 16:28:18 +0000
Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NEM00A00LD35U00@mtaout28.012.net.il> for gdb-patches@sourceware.org; Thu, 06 Nov 2014 18:25:41 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEM003JNLMTOP70@mtaout28.012.net.il>; Thu, 06 Nov 2014 18:25:41 +0200 (IST)
Date: Thu, 06 Nov 2014 16:28:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/3 v2] Implement completion limiting
In-reply-to: <1415271046-4957-4-git-send-email-gbenson@redhat.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83h9ycthsx.fsf@gnu.org>
References: <1415271046-4957-1-git-send-email-gbenson@redhat.com> <1415271046-4957-4-git-send-email-gbenson@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00118.txt.bz2

> From: Gary Benson <gbenson@redhat.com>
> Date: Thu,  6 Nov 2014 10:50:46 +0000
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS

OK for this part.

> +void
> +_initialize_completer (void)
> +{
> +  add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> +				       &max_completions, _("\
> +Set maximum number of line completion possibilities."), _("\
> +Show maximum number of line completion possibilities."), _("\

I suggest to use "completion candidates" instead of "line completion
possibilities".

> +Use this to limit the number of possibilities considered\n\
> +during line completion.  Specifying \"unlimited\" or -1\n\
          ^^^^^^^^^^^^^^^
And here use just "completion".  "Line completion" is IMO confusing,
since we don't complete "lines".

> +@table @code
> +@kindex set max-completions
> +@item set max-completions @var{limit}
> +@itemx set max-completions unlimited
> +Set the maximum number of possibilities to be considered during
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"Candidates to be shown" is better.

> +completion.  The default value is 200.  Note that setting either
> +no limit or a very large limit can cause pauses during completion.

Not "cause pauses", but rather "make completion slow", I think.

> +@kindex show max-completions
> +@item show max-completions
> +Show the maximum number of possibilities to be considered during
> +completion.

Suggest the same change here as above.

The documentation part of the patch is OK with those changes.

Thanks.