From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119307-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11601 invoked by alias); 23 Jan 2015 10:15:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11527 invoked by uid 89); 23 Jan 2015 10:15:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Jan 2015 10:15:20 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NIM00E00JXG5W00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 23 Jan 2015 12:15:18 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIM00EFCKHH0NA0@a-mtaout20.012.net.il>; Fri, 23 Jan 2015 12:15:17 +0200 (IST)
Date: Fri, 23 Jan 2015 10:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/3 v2] Implement completion limiting
In-reply-to: <m3vbjy9iqr.fsf@sspiff.org>
To: Doug Evans <xdje42@gmail.com>
Cc: gbenson@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83h9vhu7k8.fsf@gnu.org>
References: <1417094168-25868-1-git-send-email-gbenson@redhat.com> <1417094168-25868-4-git-send-email-gbenson@redhat.com> <m3y4ql4psf.fsf@sspiff.org> <20141210122233.GA7299@blade.nx> <m3mw6v4gm8.fsf@sspiff.org> <21671.20308.262958.475080@ruffy2.mtv.corp.google.com> <20150107084255.GA17867@blade.nx> <21680.36641.315766.209208@ruffy2.mtv.corp.google.com> <83a91r6lbd.fsf@gnu.org> <CADPb22TOJ2uqQKyzEpQyCrm92-ARexduUk0b2rDqJwQvdU1uLw@mail.gmail.com> <20150115153930.GA14900@blade.nx> <m3vbjy9iqr.fsf@sspiff.org>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00641.txt.bz2

> From: Doug Evans <xdje42@gmail.com>
> Date: Thu, 22 Jan 2015 21:19:24 -0800
> 
> This patch puts the warning at the end.

Thanks.

> +#if 0 //xyzdje
> +  if (max_reached)
> +    {
> +      VEC_safe_push (char_ptr, result,
> +		     xstrprintf (_("%s *** List may be truncated,"
> +				   " max-completions reached. ***"),
> +				 text));
> +    }
> +#endif

This part should probably go away.

> +/* Return a message indicating that the maximum number of completions
> +   has been reached and that there may be more.  */
> +
> +const char *
> +get_max_completions_reached_message (void)
> +{
> +  return _("*** List may be truncated, max-completions reached. ***");
> +}

I'd prefer a different wording:

  (More completions follow; omitted because max-completions exceeded.)

My problem with your wording is two-fold:

  . "may be truncated" can be interpreted to the effect that GDB
    doesn't know whether truncation really happened; I think it does

  . "reached" is inaccurate; "exceeded" is more accurate

The rest of the change in wording is just to follow the style that I
frequently see in other applications in similar cases.

The documentation parts are OK (but will need an update if you accept
the above suggestion).