From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125013 invoked by alias); 22 Aug 2015 07:31:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124997 invoked by uid 89); 22 Aug 2015 07:31:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Aug 2015 07:31:22 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NTH00L003JX3W00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 22 Aug 2015 10:31:20 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTH00K2R3K7LFC0@a-mtaout20.012.net.il>; Sat, 22 Aug 2015 10:31:20 +0300 (IDT) Date: Sat, 22 Aug 2015 07:31:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v12 08/32] Permit multiple sysroot directories In-reply-to: <20150821212111.6673.85003.stgit@host1.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83h9nrixtm.fsf@gnu.org> References: <20150821212006.6673.35100.stgit@host1.jankratochvil.net> <20150821212111.6673.85003.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00634.txt.bz2 > From: Jan Kratochvil > Date: Fri, 21 Aug 2015 23:21:11 +0200 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -35,6 +35,9 @@ show debug bfd-cache > The "/m" option is now considered deprecated: its "source-centric" > output hasn't proved useful in practice. > > +* The "set sysroot" (and "show sysroot") commands now permit multiple > + directory paths. A "path" is already a list, so I suggest this variant instead: The "set sysroot" (and "show sysroot") commands now accept PATH-style lists of directories. > -Use @var{path} as the system root for the program being debugged. Any > +Use @var{path} as the system root (or list of system roots) for the > +program being debugged. Any "or a list of system root directories" is more clear, I think. > -If @var{path} starts with the sequence @file{target:} and the target > +Multiple entries may be delimited by the host platform path separator in use. Suggest a rewording: "Multiple sysroot directories can be specified in @var{path}, separated by the host platform's path separator character (colon @samp{:} on Unix, semi-colon @samp{;} on MS-Windows, etc.)." > +If @var{path} starts with the sequence @file{target:} (even if the host > +platform path separator is character @file{:}) and the target ^^^^^^^^^^^^^^^^^^ The "character" part is redundant, and please use @samp instead of @file. > -Display the current executable and shared library prefix. > +Display the current executable and shared library prefix(es). I think "prefix" is wrong here. Why not simplify like this: Display the current value of sysroot, which is used to look for executable and shared libraries. ? Thanks.